Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export POSIXLY_CORRECT considered harmful #289

Open
mislav opened this issue Dec 21, 2012 · 1 comment
Open

export POSIXLY_CORRECT considered harmful #289

mislav opened this issue Dec 21, 2012 · 1 comment

Comments

@mislav
Copy link

mislav commented Dec 21, 2012

In e1ec57d this line was added:

export POSIXLY_CORRECT=1

And it probably fixed some issues in git-flow, but it causes breakages down the line. Specifically, when git-flow does git checkout, that can trigger post-checkout git hooks. Some people in Rubyland have hooks that integrate with some Ruby-specific tools, and have rbenv (written in bash) to manage them. Because rbenv uses a construct (process substitution) that's not posix-compatible, this environment variable causes it to fail.

This was discovered in rbenv/rbenv#222

In summary, because there might be other shell scripts down the line, git-flow should not mess up the environment for them. I propose either removing the export, or using the setting:

set -o posix

/cc @Thiana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants