feat: add winbar support #689

diegodox · 2022-05-22T08:01:56Z

Support winbar added to nvim in this PR.

shadmansaleh · 2022-05-22T17:14:45Z

I'll wait on it and see first what winbar can best be used for . Also what ideas community can come up with for winbar . vim has had winbar for long time and tbh I've only noticed it to be used in vimspector.

For now I don't think using winbar just as a statusline is a good idea . I'll prefer to have winbar to be buffer specific unlike global . A winbar specific plugin can probably pull it of better than if just treat is as part of statusline in lualine.

So I'm putting it on hold . Not entirely rejecting it nor accepting the idea.

diegodox · 2022-05-22T18:15:18Z

@shadmansaleh
I agree with you.
I implement this for me to try what I feel when use winbar as status bar. But I found #688, so I decided to create a PR for who interested in this.

btw I think winbar is a nice place to have information like nvim-gps, lsp-signature's statusline and lsp status.

lkhphuc · 2022-05-23T01:48:25Z

@diegodox exactly what I want. There is a lot of buffer specific info in my global statusline at the moment.
Just putting the file name > class > method > matchparen of the current cursor position is probably all I want for the winbar.

diegodox · 2022-05-23T05:54:32Z

PS: I found winbar is only reasonable place to show filename of each buffer (especially inactive buffer) with global status line.

rockyzhang24 · 2022-05-23T22:55:36Z

The most useful points of winbar are:

Full path of the filename (%F)
LSP symbol path (aerial.nvim has API to output this)
Window number (vim.api.nvim_win_get_number())

Setting them is very easy and no need further supports. I believe a fancy statusline is necessary but a plus fancy winbar at the top will be distracting. Also, a verbose and complicated winbar will get truncated and making it meaningless at all.

bellini666 · 2022-05-23T23:00:26Z

Sorry for being totally off topic here guys...

But @rockyzhang24, do you mind sharing your font and color scheme from that screenshot?

rockyzhang24 · 2022-05-23T23:05:22Z

@bellini666 No problem.

do you mind sharing your font and color scheme from that screenshot?

Font: JetBrainsMono
Color scheme: nightfox.nvim and I configured some colors that are not easily distinguished (See this please if you need: https://github.com/rockyzhang24/dotfiles/blob/master/.config/nvim/lua/plugin/nightfox.lua)

barrett-ruth · 2022-06-14T15:31:29Z

Furthermore, with the creation of nvim-navic, I think the community has certainly made up it's mind about the utility of the winbar.

alex-popov-tech · 2022-06-14T19:30:50Z

imho statusline and winbar aim different purposes, statusline for more global things, which are shared across splits, and winbar are about some specific splint only

joeveiga · 2022-06-14T22:09:57Z

@alex-popov-tech I think the ideal approach would be to be flexible enough for users to display whatever information they want on each. Like we do now with lualine sections, but having an extra set of section keys in the configuration for winbar sections. It already supports statusline and tabline this way, why not winbar as well?

In a perfect world users would be able to add lualine components and extensions currently used for statusline to the winbar, and vice-versa.

As you point out, a popular configuration could be winbar for buffer specific info and statusline for global/project level info. Another one could be, for example, statusline for the focused buffer (with a more detailed view) and winbar for inactive buffers. Someone might not care about diagnostic info on inactive buffers, while someone else might want to see which lsp clients are attached to each buffer instead of globally (for whatever reason).

barrett-ruth · 2022-06-16T03:33:31Z

@diegodox I'd like to add that because you set the global winbar (vim.go instead of vim.wo) to winbar() it becomes difficult to disable lualine winbar on certain files in a different window. For example, disabling the winbar on NvimTree sidebar becomes basically impossible because setting vim.wo.winbar subsequently has no effect.

Sorry if this is bothersome but I know a lot of people will be bothered by there being an empty winbar essentially wasting space in a buffer.

Pull in winbar changes form pr #689 and adapt them Co-authored-by: shadmansaleh <13149513+shadmansaleh@users.noreply.github.com>

shadmansaleh · 2022-07-12T10:22:48Z

@diegodox I've pulled the changed from this branch to #736 .

Would appreciate if you guys interested in the feature can test it.

diegodox · 2022-07-12T14:57:24Z

@barrett-ruth Thank you for pointing out vim.go.winbar will not respect vim.wo.winbar. I'm planning to fix that (use vim.wo.winbar instead of vim.go.winbar). And sorry for late reply.
But sorry again, I have no time to impl that right now. Anyone who want to impl that feature are welcome. :)
I might find time in 1 month.

diegodox · 2022-07-12T15:05:05Z

Need advice on implementation approach, is autocmd right choice to set winbar window option? or more simpler way exists?

diegodox · 2022-07-12T15:07:03Z

@shadmansaleh I will look and test that branch, thank you.

shadmansaleh · 2022-07-15T15:32:36Z

Thank you for pointing out vim.go.winbar will not respect vim.wo.winbar. I'm planning to fix that (use vim.wo.winbar instead of vim.go.winbar). And sorry for late reply.
But sorry again, I have no time to impl that right now. Anyone who want to impl that feature are welcome. :)

addressing that issue is the purpose of #736 . So lualine can keep running even when options are unset.

* feat: refresh lualine based on timer. * fix config test * fix lag on win change issue * handle errors in timer callback * feat: add winbar support Pull in winbar changes form pr #689 and adapt them Co-authored-by: shadmansaleh <13149513+shadmansaleh@users.noreply.github.com> * make winbar disapear when winbar evals empty * only update stl of curwin with globalstatus * properly clear win local stl and wbr opts * add version guards for winbar feature * only add winbar if height > 1 * fix tests? * refresh lualine on ModeChanged event * ignore floating windows for refresh * properply restore options to previous state * fix stl not updating in cmd mode + some optimizations * fix tests on <nvim-0.7 * merge status_dispatch & winbar_dispatch + winbar support for extensions * fix globalstatus option not live updating * update docs * feat: allow disabling winbar and statusline separately * fix tests * fix: winbar some times oddly throwing errors about not having space in floating windows. This implements a temporary workaround the issue(neovim/neovim#19464) until the bug in neovim gets fixed. Co-authored-by: Diego Fujii <android.mxdiego9@gmail.com>

shadmansaleh · 2022-07-22T13:31:20Z

Merged with #736 in 53aa3d8

) * feat: refresh lualine based on timer. * fix config test * fix lag on win change issue * handle errors in timer callback * feat: add winbar support Pull in winbar changes form pr nvim-lualine#689 and adapt them Co-authored-by: shadmansaleh <13149513+shadmansaleh@users.noreply.github.com> * make winbar disapear when winbar evals empty * only update stl of curwin with globalstatus * properly clear win local stl and wbr opts * add version guards for winbar feature * only add winbar if height > 1 * fix tests? * refresh lualine on ModeChanged event * ignore floating windows for refresh * properply restore options to previous state * fix stl not updating in cmd mode + some optimizations * fix tests on <nvim-0.7 * merge status_dispatch & winbar_dispatch + winbar support for extensions * fix globalstatus option not live updating * update docs * feat: allow disabling winbar and statusline separately * fix tests * fix: winbar some times oddly throwing errors about not having space in floating windows. This implements a temporary workaround the issue(neovim/neovim#19464) until the bug in neovim gets fixed. Co-authored-by: Diego Fujii <android.mxdiego9@gmail.com>

diegodox added 3 commits May 22, 2022 17:01

add winbar

8f66230

update spec

09eb387

fix comment

35badba

shadmansaleh mentioned this pull request May 25, 2022

Feat: Winbar support #692

Closed

shadmansaleh added the review:later label Jun 8, 2022

shadmansaleh mentioned this pull request Jul 12, 2022

feat: refresh lualine based on timer + winbar support. #736

Merged

shadmansaleh pushed a commit that referenced this pull request Jul 12, 2022

feat: add winbar support

d2123ae

Pull in winbar changes form pr #689 and adapt them Co-authored-by: shadmansaleh <13149513+shadmansaleh@users.noreply.github.com>

shadmansaleh closed this Jul 22, 2022

diegodox deleted the winbar branch July 29, 2022 17:24

diegodox restored the winbar branch August 4, 2022 08:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add winbar support #689

feat: add winbar support #689

diegodox commented May 22, 2022

shadmansaleh commented May 22, 2022 •

edited

Loading

diegodox commented May 22, 2022 •

edited

Loading

lkhphuc commented May 23, 2022 •

edited

Loading

diegodox commented May 23, 2022

rockyzhang24 commented May 23, 2022 •

edited

Loading

bellini666 commented May 23, 2022

rockyzhang24 commented May 23, 2022 •

edited

Loading

barrett-ruth commented Jun 14, 2022

alex-popov-tech commented Jun 14, 2022

joeveiga commented Jun 14, 2022 •

edited

Loading

barrett-ruth commented Jun 16, 2022 •

edited

Loading

shadmansaleh commented Jul 12, 2022

diegodox commented Jul 12, 2022 •

edited

Loading

diegodox commented Jul 12, 2022 •

edited

Loading

diegodox commented Jul 12, 2022

shadmansaleh commented Jul 15, 2022 •

edited

Loading

shadmansaleh commented Jul 22, 2022 •

edited

Loading

feat: add winbar support #689

feat: add winbar support #689

Conversation

diegodox commented May 22, 2022

shadmansaleh commented May 22, 2022 • edited Loading

diegodox commented May 22, 2022 • edited Loading

lkhphuc commented May 23, 2022 • edited Loading

diegodox commented May 23, 2022

rockyzhang24 commented May 23, 2022 • edited Loading

bellini666 commented May 23, 2022

rockyzhang24 commented May 23, 2022 • edited Loading

barrett-ruth commented Jun 14, 2022

alex-popov-tech commented Jun 14, 2022

joeveiga commented Jun 14, 2022 • edited Loading

barrett-ruth commented Jun 16, 2022 • edited Loading

shadmansaleh commented Jul 12, 2022

diegodox commented Jul 12, 2022 • edited Loading

diegodox commented Jul 12, 2022 • edited Loading

diegodox commented Jul 12, 2022

shadmansaleh commented Jul 15, 2022 • edited Loading

shadmansaleh commented Jul 22, 2022 • edited Loading

shadmansaleh commented May 22, 2022 •

edited

Loading

diegodox commented May 22, 2022 •

edited

Loading

lkhphuc commented May 23, 2022 •

edited

Loading

rockyzhang24 commented May 23, 2022 •

edited

Loading

rockyzhang24 commented May 23, 2022 •

edited

Loading

joeveiga commented Jun 14, 2022 •

edited

Loading

barrett-ruth commented Jun 16, 2022 •

edited

Loading

diegodox commented Jul 12, 2022 •

edited

Loading

diegodox commented Jul 12, 2022 •

edited

Loading

shadmansaleh commented Jul 15, 2022 •

edited

Loading

shadmansaleh commented Jul 22, 2022 •

edited

Loading