Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filesystem): add BEFORE_FILE_{ADD/DELETE} events #1657

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pynappo
Copy link
Collaborator

@pynappo pynappo commented Jan 14, 2025

Closes #1276

Pinging @igorlfs and @mehalter - does anything needs a change? the LSP says only the URIs need to be passed in so I'm just passing the filenames over.

@mehalter
Copy link
Contributor

This looks great! One thing I noticed is you are returning immediately after if the event returns that the operation was handled. This seems like a good idea since it gives the user control over the add/delete, but should we also trigger the after events as well just in case the user has added custom events for that?

@igorlfs
Copy link

igorlfs commented Jan 14, 2025

Hey there! I think you meant to ping @antosha417, the original author of nvim-lsp-file-operations? I only have a fork with some (very) minor changes

@pynappo
Copy link
Collaborator Author

pynappo commented Jan 18, 2025

This looks great! One thing I noticed is you are returning immediately after if the event returns that the operation was handled. This seems like a good idea since it gives the user control over the add/delete, but should we also trigger the after events as well just in case the user has added custom events for that?

I think it makes sense, although the other BEFORE events will need to be updated as well.

Hey there! I think you meant to ping @antosha417, the original author of nvim-lsp-file-operations? I only have a fork with some (very) minor changes

Yeah i meant to ping them instead, apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BEFORE_FILE_ADD and BEFORE_FILE_DELETE events
3 participants