Concealer Issues Thread #292

vhyrro · 2022-01-01T18:43:23Z

Hey! This thread exists to basically catch all of the bugs that the new concealer implementation may be causing. Post your problems here!
Aand here's the longer version of the above TL;DR:

Good News

Let's start with the great news: we've massively improved the performance of Neorg's concealer.

I wish I were joking but it's gotten to the point where the bottleneck is no longer Neorg but the code that performs treesitter highlighting in neovim 😂. I did a bunch of testing on over 100k+ loc Neorg documents and after doing :TSBufDisable highlight to prevent the lag that TS was causing things still manage to work smoothly on my machine.

The bad news?

It's definitely not bug free.

Now that our concealer does updates incrementally there's definitely a chance that it'll miss a line or two when concealing in certain circumstances. If you have a problem with the concealer, or something doesn't work as intended, please post your issue here!.
I'll be trying to fix them as I go.

A feature was dropped...

With the dawn of the more performant concealer we've temporarily dropped the TODO item completion level feature - you know, the one that displayed (0 of 3) [0% complete] on headings when they had a TODO list under them? It's gone for now.

I suppose I owe you an explanation as to why we've decided to do this. Before our update the concealer would reparse the entire buffer every single time you changed some text or left insert mode. As you can imagine this made it really slow. Just to clarify we didn't want to make it this bad-performing in the first place, but there were certain bugs in nvim_buf_attach that prevented us from properly doing incremental updates then.

The thing is now that everything is happening incrementally we cannot properly recalculate TODO item counts without requiring more context than a single line - and requiring more context greatly slows down the concealer again.

We'll be working hard on trying to bring it back, but we really wanted to push these new changes to you guys without having you wait another week.

UPDATE: Forgot to update this thread but that has been reimplemented now as well. If you have problems with the TODO item completion levels then be sure to let me know here too!

Hope you understand!

The text was updated successfully, but these errors were encountered:

vhyrro · 2022-01-01T19:33:26Z

First bug I found myself: markup concealing was not autotriggering on files lower than 1250 lines, that's been fixed in bfe3056 now :)

max397574 · 2022-01-03T16:19:21Z

Concealing on wrapped links is broken:
wrapped:

not wrapped:

danymat · 2022-01-04T10:39:29Z

The : on https://is concealed:

Without conceal:

mrossinek · 2022-01-04T22:05:29Z

Concealing on wrapped links is broken:

This is potentially tricky with how things are done currently in the concealer. I will need to take a look at Vhyrro's rewritten code though since there have been quite some changes. The problem will be that we need to iterate the char in the TS range one by one rather than just rely on the length of the node.

mrossinek · 2022-01-04T22:07:06Z

The : on https:// is concealed:

Yes, I have encountered this too. The problem is that the : get's recognized as a link_modifier. I will try if I can fix the TS parser to disregard single link_modifier nodes (i.e. if they do not occur in pairs). That should fix this.

On another note: those screenshot of yours are still using Markdown-like link syntax!

mrossinek · 2022-01-05T20:40:54Z

Concealing on wrapped links is broken:

This is potentially tricky with how things are done currently in the concealer. I will need to take a look at Vhyrro's rewritten code though since there have been quite some changes. The problem will be that we need to iterate the char in the TS range one by one rather than just rely on the length of the node.

A followup question to this @max397574: is this soft-wrapped? If so, I don't think there is a way for us to handle this. Neovim itself would have to handle wrapping extmarks..

danymat · 2022-01-05T20:42:42Z

On another note: those screenshot of yours are still using Markdown-like link syntax!

Right, lmao

max397574 · 2022-01-05T21:05:25Z

Concealing on wrapped links is broken:

This is potentially tricky with how things are done currently in the concealer. I will need to take a look at Vhyrro's rewritten code though since there have been quite some changes. The problem will be that we need to iterate the char in the TS range one by one rather than just rely on the length of the node.

A followup question to this @max397574: is this soft-wrapped? If so, I don't think there is a way for us to handle this. Neovim itself would have to handle wrapping extmarks..

Not sure what soft-wrapped is
it's just a line longer than the screen is width

nvim-neorg/neorg#292 (comment)

mrossinek · 2022-01-05T21:07:42Z

The : on https:// is concealed:

Yes, I have encountered this too. The problem is that the : get's recognized as a link_modifier. I will try if I can fix the TS parser to disregard single link_modifier nodes (i.e. if they do not occur in pairs). That should fix this.

@danymat This should be fixed now. Can you please update your TS parser to verify?

danymat · 2022-01-05T21:09:38Z

@danymat This should be fixed now. Can you please update your TS parser to verify?

It is indeed ! thanks !

mrossinek · 2022-01-05T21:09:52Z

Not sure what soft-wrapped is
it's just a line longer than the screen is width

See :help 'wrap'. If you use :set nowrap then a line which is longer than your window width will not get wrapped but instead extends to the right (you then need to scroll horizontally to see the rest).

vhyrro · 2022-01-05T21:24:34Z

Seems to be a problem with generic line breaks as well.

This is {a
test}[with custom text]

mrossinek · 2022-01-05T21:30:31Z

Seems to be a problem with generic line breaks as well.

Yep. That's the original problem I discuss here: #292 (comment)

karlc1 · 2022-01-10T13:18:01Z

I just started trying neorg today, so I just assume that this is unintended behavior.
When I create a link, the link marker is still being rendered, but its foreground color is set to the normal bg color, so it looks like a bunch of whitespace before the custom text (but i can still yank the text or see it if highlighted in visual mode)

An inline link {| my marker}[with custom text].

looks like this in the editor

An inline link with custom text.

max397574 · 2022-01-10T13:42:19Z

I think I know what's the problem
could you send your neorg config and a screenshot?

karlc1 · 2022-01-10T13:48:32Z

I cannot take a screenshot at the moment, but it really looks just as described; like a bunch of whitespace of equal length as the marker.

Here is the config https://github.com/karlc1/nvim/blob/main/lua/plugins.lua#L691

vhyrro · 2022-01-23T16:42:19Z

Just a quick heads up that i've managed to fix some bugs related to the link concealing as discussed earlier above.

Those should now be highlighted properly :)

(also @karlc1 if you haven't already then updating Neorg should fix your problems you've described above) :)

esquires · 2022-01-23T17:13:54Z

Thanks for the fixes! Here is one more. For the line

Here is {:inbox:}[my link]

with markup_preset set to brave I get the following:

If I then enter insert mode on a line above the link by hitting o (not i and not on the link itself) it seems to get fixed:

However, if I then enter insert mode on the link line it gets reset to the first markup.

karlc1 · 2022-01-27T10:12:10Z

@vhyrro I use neovim nightly and neorg on the latest tag, and i still don't think that the links look right.

This line
test: {:some_file:}[link!].

Looks like this:
test: some_file link!
(with the 'some_file word in faded color')

I would expect it to look like this:
test: link!

max397574 · 2022-01-27T10:14:23Z

Check out the markup preset here: https://github.com/nvim-neorg/neorg/wiki/Concealer
This is expected

karlc1 · 2022-01-27T13:53:59Z

I see, did not realize this. The 'brave' preset works as I want it to, thanks for the clarification

esquires · 2022-01-27T14:12:45Z

I see, did not realize this. The 'brave' preset works as I want it to, thanks for the clarification

Interesting it works on your end with the brave setting. Here is how the brave setting works for me for test: ⁠⁠⁠⁠⁠⁠⁠⁠⁠⁠{:some_file:}[link!].

Can you post your config? Perhaps you have a setting that I don't that is making it work.

max397574 · 2022-01-27T14:36:34Z

this is because stuff breaks with the joiner char
that's why we introduced the other presets

esquires · 2022-01-27T14:40:40Z

this is because stuff breaks with the joiner char
that's why we introduced the other presets

Thanks for the clarification. is it fixable or is brave not intended for use?

karlc1 · 2022-01-27T15:27:16Z

@esquires It does look like that for me if I enter insert mode on a line with a link, and then go back to normal mode but stay with the cursor on the same line. However, when I move the cursor to a different line it looks correct again.
I have a pretty basic config i believe https://github.com/karlc1/nvim/blob/main/lua/plugins.lua#L680

top4ek · 2023-09-19T14:58:09Z

Concealer hides URL properly, but affected by word warp — URL's hidden, but space for that still in place.

champignoom · 2023-09-19T15:30:37Z

Concealer hides URL properly, but affected by word warp — URL's hidden, but space for that still in place.

duplicate of #929

akbng · 2023-10-14T21:04:05Z

HI!
Similar to @asmdv and @mike-lloyd03, I have issues only with the italics, superscripts & subscripts.
I have checked the terminal (using Kitty) and it works fine. Also, italics work fine with comments in other files.

I'm using custom icons for the headings!

Here's the terminal output for the following

Am not sure about the subscript and superscript part but the ITALICS should work.

Drew-Daniels · 2023-10-23T20:21:41Z

[SOLVED]: tmux does not support bold and italic fonts out of the box.

If you use tmux, you'll need to ensure that you have set -g default-terminal "tmux-256color" in your tmux.conf

[ISSUE]:
OS: OSX Ventura 13.6 (22G120)
Neovim: v0.9.2
Terminal: iTerm 2 3.4.21

I have similar issues to others where it doesn't appear that these markup formats work on my machine:

italic
strikethrough

This is after I set my terminal to use the font-meslo-lg-nerd-font font, installed via brew

Here is my neorg config:

require("neorg").setup({
  load = {
    ["core.defaults"] = {},
  }
})

terminal section from running :checkhealth

terminal ~
- key_backspace (kbs) terminfo entry: `key_backspace=^H`
- key_dc (kdch1) terminfo entry: `key_dc=\E[3~`
- $TERM_PROGRAM="iTerm.app"
- $COLORTERM="truecolor"

bottd · 2023-12-06T13:26:22Z

After upgrading from nvim 0.9 to nightly 0.10, I am seeing the closing bracket on links if they end with an emoji

On nvim 0.9

On nvim nightly

rodhash · 2023-12-06T15:42:02Z

I have a similar issue when opening toc:

Nvim: NVIM v0.10.0-dev-a84b454
Neorg: bf3daa22

chasing-freedom · 2023-12-30T13:48:26Z

After upgrading from nvim 0.9 to nightly 0.10, I am seeing the closing bracket on links if they end with an emoji

On nvim 0.9

On nvim nightly

Same issue in CJK characters

On nvim 0.9.5

On nvim v0.10.0-dev-1956+gec7453804

Test link {https://github.com/}[文本]

SOLVED: After update to NVIM v0.10.0-dev-1991+gdd00b6b44

birangsworld · 2024-01-02T08:45:06Z

Hi there! new here so hopefully im posting to the right issue post
it seems ordered list doesnt render numbers beyond 20 and everything after that is just shown as ~

max397574 · 2024-01-02T08:55:18Z

@birangsworld that's actually the expected behavior because there aren't any characters to be used higher than that

there is an option in the concealer config which allows you to use complete numbers

birangsworld · 2024-01-02T15:34:26Z

@birangsworld that's actually the expected behavior because there aren't any characters to be used higher than that

there is an option in the concealer config which allows you to use complete numbers

Any chance you could help me out with setting the correct option in the [core.concealer] config?

rodhash · 2024-01-02T23:36:24Z

I have a similar issue when opening toc:

Nvim: NVIM v0.10.0-dev-a84b454 Neorg: bf3daa22

This is now fixed, TOC is awesome!

I couldn't find which specific commit did the trick but thanks to whomever did that

sarawang9012 · 2024-01-12T00:32:58Z

[SOLVED]: tmux does not support bold and italic fonts out of the box.

If you use tmux, you'll need to ensure that you have set -g default-terminal "tmux-256color" in your tmux.conf

Thank you. I was having issue of bold, italic and strikethrough in my tmux. After applying set -g default-terminal "tmux-256color" in tmux.conf, italic and strikethrough work perfectly. Only bold is not working. I checked its my terminal not supporting it. I am using wsl2 with ubuntu22.04, in case anyone having the same issue, you need to set "intenseTextStyle": "bold" to profiles.defaults item in windows terminal's settings.json file. For more information, refer to
109

Drew-Daniels · 2024-01-22T02:01:14Z

Posting this here, because I think it might help others. But in my case, I wasn't seeing italics or strikethroughs in iTerm2 (and while outside tmux), because in my .zshrc, I had explicitly had export TERM=screen-256colors.

I don't remember why I had set this at one point, but once I removed this, and configured iTerm2 to use xterm-256color everything worked as expected, and I was able to see italics and strikethrough in neovim correctly

bwkam · 2024-02-17T00:46:33Z

icon is sorta clipped

that's how the others look like

edit: that's only on kitty, they are fine on alactricitty

shittened · 2024-02-20T16:07:02Z

Bold, italic, underline not working for me. I saw some suggestion on how to fix above but none worked. Bold, italic, underline work outside of neorg. Im using kitty terminal on endeavour, everything up to date

mateuscqueiros · 2024-02-21T03:41:07Z

@Kiefciman same problem here

champignoom · 2024-02-21T08:57:43Z

@Kiefciman @mateuscqueiros There was a breaking change related to highlighting. Try add tag = "v7.0.0" (see 0012776)

shittened · 2024-02-21T11:48:51Z

@champignoom this fixed it, thx

carterprince · 2024-02-24T19:56:29Z

@Kiefciman @mateuscqueiros There was a breaking change related to highlighting. Try add tag = "v7.0.0" (see 0012776)

This fixes underlines but not bold or italics for me.

I have determined it's not an issue with my terminal or fonts because in Neorg the "title" in document.meta still shows in bold.

champignoom · 2024-02-28T12:04:01Z

@carterprince see champignoom/kanagawa.nvim@582fe0a

jonnypolite · 2024-02-28T18:42:05Z

@Kiefciman @mateuscqueiros There was a breaking change related to highlighting. Try add tag = "v7.0.0" (see 0012776)

This doesn't seem to make any difference to me (I also can't get any text decoration to work inside neorg. bold, italic, strikethrough, etc). Is there something I should do after that change other than restart neovim?

Here's what I've already tried to resolve this issue:

:set conceallevel=2 (this just makes the ** or // go away but doesn't change the text)
:highlight mytest cterm=strikethrough gui=strikethrough followed by :highlight mytest (that works in the sense that I see strikethrough)
verified with echo commands at the command prompt that iterm2 can output the variants
Also ran :Neorg sync-parsers seemingly successfully

albywalby · 2024-03-21T09:13:42Z

On windows Terminal and some headings don't seem to render properly

zvpyp · 2024-03-25T04:16:15Z

On fedora 39, first element of ordered lists is ignored in counting

qZhang88 · 2024-04-09T10:25:16Z

concealer not working, and checkhealth show module not recognized

neorg ~
- Checking configuration...
- Checking `load` table...
- WARNING You are attempting to load a module core.concealer` which is not recognized by Neorg at this time. You may receive an error upon launching Neorg.
- OK Module declaration `core.dirman` is well-formed
- OK Module declaration `core.defaults` is well-formed
- WARNING You are attempting to load a module `core.ui.calendar` which is not recognized by Neorg at this time. You may receive an error upon launching Neorg.
- OK Default configuration for logger provided, Neorg will not output debug info.
- Checking existence of dependencies...
- OK Required dependency `vhyrro/luarocks` found!
- Checking existence of luarocks dependencies...
- OK Critical dependencies are installed. You are free to use Neorg!
- WARNING If you ever encounter errors please rerun `:Lazy build neorg` again :)

sev1n75 · 2024-07-05T12:28:07Z

Hi, I wrote vim.o.conceallevel = 2 in my config file and the value of conceallevel is correctly set to be 2 in normal *.nrog file, however the conceallevel value of TOC window is still 0 as default.

Nvim: NVIM v0.10.0
Neorg: 99b32492b836b64a5ff454

glyh · 2024-07-27T04:04:12Z

Latex rendering seems to be stop work for me from some point on:
I'm using lazy.nvim:

  {
    "vhyrro/luarocks.nvim",
    priority = 1001,
    opts = {
      rocks = { "magick" },
    },
    config = true,
  },
  {
    "3rd/image.nvim",
    dependencies = { "luarocks.nvim" },
    config = true,
  },

{
    "nvim-neorg/neorg",
    dependencies = { "luarocks.nvim" },
    lazy = false, -- Disable lazy loading as some `lazy.nvim` distributions set `lazy = true` by default
    -- version = "*", -- Pin Neorg to the latest stable release
    config = function()
      require("neorg").setup {
        load = {
          ["core.defaults"] = {},
          ["core.export"] = {},
          ["core.export.markdown"] = {},
          ["core.concealer"] = {},
          ["core.completion"] = {
            config = {
              engine = "nvim-cmp",
            },
          },
          ["core.dirman"] = {
            config = {
              workspaces = {
                knowledge = "~/Documents/Knowledge/Notes Base",
              },
              default_workspace = "knowledge",
            },
          },
          ["core.integrations.image"] = {},
          ["core.latex.renderer"] = {},
        },
      }
    end,
  }

Anyone have any ideas?

vhyrro pinned this issue Jan 1, 2022

danymat added the module: existing modules Issue related to existing Modules label Jan 2, 2022

mrossinek added a commit to nvim-neorg/tree-sitter-norg that referenced this issue Jan 5, 2022

fix: only detect link_modifier around an attached_modifier

6a03bbe

nvim-neorg/neorg#292 (comment)

vhyrro added a commit that referenced this issue Jan 6, 2022

fix(concealer): errors when leaving Neovim right after BufEnter (#292)

dd0f29b

vhyrro added a commit that referenced this issue Jan 24, 2022

fix(concealer): errors when leaving Neovim right after BufEnter (#292)

b796cd4

This was referenced Feb 28, 2024

doc: pin kanagawa to the last commit with legacy highlight group name #1322

Merged

:Neorg sync-parsers should pin parser to the version that corresponds to neorg version #1323

Closed

vhyrro unpinned this issue Mar 24, 2024

max397574 mentioned this issue May 28, 2024

(Upstream) Concealed formula width incorrectly identified as non-concealed when linewrapping #1444

Closed

2 tasks

Concealer Issues Thread #292

Concealer Issues Thread #292

Comments

vhyrro commented Jan 1, 2022 • edited Loading

Good News

The bad news?

A feature was dropped...

vhyrro commented Jan 1, 2022 • edited Loading

max397574 commented Jan 3, 2022

danymat commented Jan 4, 2022

mrossinek commented Jan 4, 2022

mrossinek commented Jan 4, 2022 • edited Loading

mrossinek commented Jan 5, 2022

danymat commented Jan 5, 2022

max397574 commented Jan 5, 2022

mrossinek commented Jan 5, 2022

danymat commented Jan 5, 2022

mrossinek commented Jan 5, 2022

vhyrro commented Jan 5, 2022

mrossinek commented Jan 5, 2022

karlc1 commented Jan 10, 2022

max397574 commented Jan 10, 2022

karlc1 commented Jan 10, 2022

vhyrro commented Jan 23, 2022

esquires commented Jan 23, 2022

karlc1 commented Jan 27, 2022

max397574 commented Jan 27, 2022

karlc1 commented Jan 27, 2022

esquires commented Jan 27, 2022

max397574 commented Jan 27, 2022

esquires commented Jan 27, 2022

karlc1 commented Jan 27, 2022

top4ek commented Sep 19, 2023 • edited Loading

champignoom commented Sep 19, 2023

akbng commented Oct 14, 2023

Drew-Daniels commented Oct 23, 2023 • edited Loading

bottd commented Dec 6, 2023

rodhash commented Dec 6, 2023 • edited Loading

chasing-freedom commented Dec 30, 2023 • edited Loading

birangsworld commented Jan 2, 2024

max397574 commented Jan 2, 2024

birangsworld commented Jan 2, 2024

rodhash commented Jan 2, 2024

sarawang9012 commented Jan 12, 2024 • edited Loading

Drew-Daniels commented Jan 22, 2024 • edited Loading

bwkam commented Feb 17, 2024 • edited Loading

shittened commented Feb 20, 2024

mateuscqueiros commented Feb 21, 2024

champignoom commented Feb 21, 2024

shittened commented Feb 21, 2024

carterprince commented Feb 24, 2024 • edited Loading

champignoom commented Feb 28, 2024 • edited Loading

jonnypolite commented Feb 28, 2024 • edited Loading

albywalby commented Mar 21, 2024

zvpyp commented Mar 25, 2024

qZhang88 commented Apr 9, 2024

sev1n75 commented Jul 5, 2024 • edited Loading

glyh commented Jul 27, 2024

vhyrro commented Jan 1, 2022 •

edited

Loading

vhyrro commented Jan 1, 2022 •

edited

Loading

mrossinek commented Jan 4, 2022 •

edited

Loading

top4ek commented Sep 19, 2023 •

edited

Loading

Drew-Daniels commented Oct 23, 2023 •

edited

Loading

rodhash commented Dec 6, 2023 •

edited

Loading

chasing-freedom commented Dec 30, 2023 •

edited

Loading

sarawang9012 commented Jan 12, 2024 •

edited

Loading

Drew-Daniels commented Jan 22, 2024 •

edited

Loading

bwkam commented Feb 17, 2024 •

edited

Loading

carterprince commented Feb 24, 2024 •

edited

Loading

champignoom commented Feb 28, 2024 •

edited

Loading

jonnypolite commented Feb 28, 2024 •

edited

Loading

sev1n75 commented Jul 5, 2024 •

edited

Loading