Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for new link parsing + syntax #178

Merged
merged 198 commits into from
Dec 13, 2021
Merged

Support for new link parsing + syntax #178

merged 198 commits into from
Dec 13, 2021

Conversation

vhyrro
Copy link
Member

@vhyrro vhyrro commented Nov 2, 2021 •
edited
Loading

This PR adds support for a few things:

  • Add support for new link parsing available in the attached-modifiers branch of the treesitter parser
  • Basic queries for highlighting attached modifiers
  • "Won't do" syntax for links - [-] Something I won't do
  • Completely rewrite enter link on <CR> functionality. Will allow for more efficient and less janky code in general.
    • Support new link syntax that disallows several file targets and only allows for one
    • Support @ location tag ([link](@non-norg-file.txt))
    • Support file-only locations ([link](:some-norg-file:)

mrossinek and others added 27 commits October 12, 2021 23:35
@mrossinek
WIP: TS-based concealing
bd1ced7 
Using the workaround explained in [1] we can conceal basic markup
entirely based on the TS syntax tree. While this has some minor edge
cases (especially considering the display of a colorcolumn).

This commit also introduces a new conceal setting called `volatile`
which will make icons.. well.. volatile! That means, that the concealing
will be lifted when the cursor is above the extmarks start position
making editing possible in a much easier fashion.

[1]: neovim/neovim#15706 (comment)
@mrossinek
Some cleanup
08efa02
@mrossinek
Clean-up after rebase
68ee89d
@mrossinek
Stylua...
1bc1084
@vhyrro
feat: create queries and setup for new links
400d1ce
@vhyrro
feat: add support for new external file link syntax
3a0300d
@vhyrro
feat: support new strict_link node type
3843747
@vhyrro
Merge branch 'unstable' into new-links
3ee322a
@vhyrro
Merge branch 'unstable' into new-links
b258a8f
@mrossinek
Remove volatile icons again
f858034 
Instead we now remove extmarks only around the cursor upon InsertEnter.
@mrossinek
Minor naming updates
6c21a9d
@mrossinek
feat: conceal nested markup
beb7eee
@mrossinek
fix: simplify nested markup concealing
b4cb21f 
Some changes in the TS parser now made all this soooo much simpler!
@vhyrro
Merge branch 'unstable' into new-links
71239fb
@vhyrro
docs: prepare docs for new syntax changes
a88f9de
@vhyrro
feat: add new @code languages and remove ELOCR code
ff64658
@vhyrro
feat: add queries for new markup nodes
51a7603
@mrossinek
Merge branch 'unstable' into ts-based-concealing
8134ca2
@mrossinek
Also conceal inline math
7d8ba42
@mrossinek
Also conceal variable references
5499155
@vhyrro
Changes to the core:
3877836 
- Add new `core.started` event that you can hook into via user callbacks
- Cleanup to allow now `core.norg.esupports.hop` implementation
- Update README.md with new stuff
@vhyrro
feat: add the ability to locate a link under the cursor
65994e9
@mrossinek
Merge branch 'unstable' into ts-based-concealing
d196c77
@mrossinek
feat: migrate URL concealing to treesitter queries
dc908e3
@mrossinek
Unify highlight definitions with TS integration
24897b7
@mrossinek
Update docs
074094f
@mrossinek
Fix disallowed example to not break TS on help page
b02598f
@vhyrro
Copy link
Member Author

vhyrro commented Nov 2, 2021

new-highlights

This is just a showcase of the new highlights that will be available for links :D
Much richer than the basic regex highlights we had earlier.

danymat and others added 13 commits December 10, 2021 11:39
@danymat
feat(docgen) Update generation of public config
f397bd0
@danymat
feat(docgen) Pretty customization of public config
c4bd685
@danymat
fix(docgen) Indentation and default text
82d8707
@danymat
fix(docgen) Indentation
95ef654
@mrossinek
fix: make minimal init files compatible with core maintainer setup
ad9c607
@mrossinek
feat: sort inbuilt modules alphabetically (and wrap them into a fold)
a1bb823
@vhyrro
docs(news.norg): update news.norg
0af464c
@vhyrro
fix: remove version from core.neorgcmd
79c62d5
@vhyrro
docs(news.norg): reword a few bits here and there
56d58ad
@vhyrro
feat(core.norg.news): finish off the module
8cab56b 
- Remove popup-based system in favour of notification-based system
- Add `:Neorg news` command
- Add `message` and `show_at_startup` flags
@mrossinek
fix: conceal only actual markup chars
d2c42a9 
Rather than concealing the full text nodes, we only conceal the actual
markup in order to avoid issues when dealing with multi-line markup (for
example).
@mrossinek
fix: simplify markup TS queries
985ccf0
@vhyrro
docs(spec): pretty much finalize the spec for release
39e4db6
@vhyrro vhyrro marked this pull request as ready for review December 13, 2021 17:56
@vhyrro vhyrro merged commit 3ee00bd into unstable Dec 13, 2021
@vhyrro vhyrro deleted the new-links branch December 13, 2021 17:57
vhyrro added a commit that referenced this pull request Jan 24, 2022
@vhyrro
feat: add full support for new link parsing/syntax (#178)
7e2dacf
esquires pushed a commit to esquires/neorg that referenced this pull request Apr 12, 2022
@vhyrro
feat: add full support for new link parsing/syntax (nvim-neorg#178)
e70bc59 
Former-commit-id: 757bfb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrossinek mrossinek mrossinek left review comments

Assignees

@vhyrro vhyrro

Labels
feature Issues related to feature proposals. Please attach a module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Link Format Jump on the only link in line with CR
4 participants
@vhyrro @mrossinek @danymat @max397574