add `core.execute` #618

tamton-aquib · 2022-10-09T18:31:03Z

This module is aimed to provide an execute command for neorg.

2022-10-28_23-26-32.mp4

Possible todos:

max397574 · 2022-10-26T16:03:33Z

perhaps call the subcommand which is now called normal either text or insert

max397574 · 2022-12-16T10:10:45Z

lua/neorg/modules/core/execute/module.lua

+                vim.api.nvim_buf_set_lines(
+                    curr_task.buf,
+                    curr_task.code_block['end'].row + 1,
+                    curr_task.code_block['end'].row + #curr_task.output + 1,


shouldn't this be the same as the start
if not lines below the code block are overwritten

This is for deleting the previous output lines if present, havent experienced any bugs yet on my side(on this line).

max397574 · 2022-12-16T10:11:27Z

lua/neorg/modules/core/execute/module.lua

-            0, 0, {}
-        )
+        -- IMP: check for existng marks and return if it exists.
+        local cr, _ = unpack(vim.api.nvim_win_get_cursor(0))


couldn't you just get rid of the , _ ?
the value would just be ignored
also
I think cr isn't a really descriptive variable name

couldn't you just get rid of the , _ ?

Was indexing the first item(row), but was testing with both.

I think cr isn't a really descriptive variable name

let me know what else you want to call it

max397574 · 2022-12-16T10:18:01Z

lua/neorg/modules/core/execute/module.lua

+end
+
+module.config.public = require("neorg.modules.core.execute.config")
+module.config.private = {}


no need to add this if it's unused

There was some settings on my local repo, will delete the line if its not used 👍🏻

max397574 · 2022-12-16T10:18:17Z

lua/neorg/modules/core/execute/module.lua

+local spinner = require("neorg.modules.core.execute.spinner")
+
+local module = neorg.modules.create("core.execute")
+local ts = require("nvim-treesitter.ts_utils")


we got a module for this
not sure what's preferred

will discuss and resolve with vhyrro 👍🏻

Here you probably want to use module.required["core.integrations.treesitter"].get_ts_utils()

max397574 · 2022-12-16T10:20:00Z

lua/neorg/modules/core/execute/spinner.lua

@@ -0,0 +1,41 @@
+-- TODO: code cleanup


@vhyrro perhaps add some standard location of things like this? (basically util files)

vhyrro · 2023-02-23T13:11:52Z

By the way, this module is not forgotten. I think about this every now and again but just have other priorities. The thought of implementing code execution does excite me though heh

laher · 2023-05-05T09:52:19Z

Hi @tamton-aquib ... I just copy-pasted this as an external module on my filesystem, and it's working beautifully for me. Very cool work. I just had to s/core.execute/external.execute/ in a few places. It's so good for my journal template to have some daily tasks which I can trigger like this - thank you 🥇

What do you think about re-creating this as an external module & publishing in its own repo, while this core module is under review? It might take a while for this to get merged as a core module, and in the meantime we could collaborate. I & others could fork & contribute. (Or I can publish my copy-paste and credit you, but that would feel like the wrong way round).

I know it belongs in core eventually, but I think that if folks could start using it now, then they would & people would help to improve it.

Thanks again

tamton-aquib · 2023-05-05T11:28:04Z

Heyyo @laher ,

What do you think about re-creating this as an external module & publishing in its own repo, while this core module is under review? It might take a while for this to get merged as a core module, and in the meantime we could collaborate

I talked to vhyrro on discord and it might take some time for him to review this PR.
So for the time being i guess you could create the fork because i wont probably be able to maintain it 😬 .

(Or I can publish my copy-paste and credit you, but that would feel like the wrong way round)

This would be better. I guess you could just link this PR instead of credits btw 😅

PS: i dont know if the code is ugly, so feel free to refactor or anything hehe

laher · 2023-05-05T20:51:45Z

Cool, I'll do that. I haven't written much lua myself, but what you've done is working & simple enough that I could add a couple of languages easily.

I'll add some linting and stuff and go from there...

I'll pop onto discord for discussion once I have something.

laher · 2023-05-06T02:45:40Z

Hi again, I've been reading the specs and getting my head around tags and norg generally, and I think I know where I'd like to take this.

Repo: https://github.com/laher/neorg-exec

I named it external.exec because it's 3 whole characters shorter, and I'm lazy. I gave it a GPL3 like neorg because it matches.
I think it'd be tidy to use ranged tags for the results sections, so it's easier to address them for re-runs. (could be verbatim or standard, depending on the use case).
I'd like to use tags to indicate how to run the code block, something like #exec cache=5m pwd=.. result.tagtype=|
also tags to present metadata about the results. exit code, code-hash for cached results, timings, etc.
I'd like to use popups instead of virtual lines for the virtual mode.

See the planning section for examples of what this might look like: https://github.com/laher/neorg-exec#planning

I'm very new to norg, so I'd appreciate some feedback about how well this tagging approach might work with norg.

OK I'll stop spamming this PR now and move discussion into discord + my repo.
Ta

tamton-aquib · 2023-08-31T06:17:52Z

Closing the PR as the development regarding this features is moved to an external module:
https://github.com/laher/neorg-exec 🎉

tamton-aquib added 3 commits October 9, 2022 23:56

add execute module base

b100c59

adding unstable normal subcommand

b1c1f97

add extra interpreted langs

5e9abcc

tamton-aquib and others added 6 commits October 26, 2022 21:41

starting compiled langs

4e199e1

adding spinner

775b2e7

check for :main param for compiled langs && moved config

5219ce1

refactor: each block has a state now

0672720

fix: working re-execution

daad5e0

Merge branch 'nvim-neorg:main' into code-execution

e35a5dc

max397574 reviewed Dec 16, 2022

View reviewed changes

tamton-aquib changed the title ~~add execute module base~~ add core.execute Dec 16, 2022

tamton-aquib and others added 5 commits January 16, 2023 17:52

Merge branch 'nvim-neorg:main' into code-execution

3b66527

less duplication, ranged_tag -> ranged_verbatim_tag, skeleton for hide

22cb9fe

feat: added hide subcommand for view and normal

e91f0d1

feat: adding materialize command (bugs present)

c8a1e3a

fixed 90% bugs (might need to make public.mode local to each cell)

d78c36d

tamton-aquib marked this pull request as ready for review January 16, 2023 15:40

tamton-aquib requested review from mrossinek and danymat as code owners January 16, 2023 15:40

Merge branch 'nvim-neorg:main' into code-execution

6262133

laher added a commit to laher/neorg-exec that referenced this pull request May 5, 2023

import code from nvim-neorg/neorg#618

8900a38

katawful mentioned this pull request May 18, 2023

Feature: Code evaluation #323

Open

1 task

tamton-aquib closed this Aug 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add `core.execute` #618

add `core.execute` #618

tamton-aquib commented Oct 9, 2022 •

edited

Loading

max397574 commented Oct 26, 2022

max397574 Dec 16, 2022

tamton-aquib Dec 16, 2022

max397574 Dec 16, 2022

tamton-aquib Dec 16, 2022

max397574 Dec 16, 2022

tamton-aquib Dec 16, 2022

max397574 Dec 16, 2022

tamton-aquib Dec 16, 2022

vhyrro Dec 16, 2022

max397574 Dec 16, 2022

vhyrro commented Feb 23, 2023

laher commented May 5, 2023

tamton-aquib commented May 5, 2023

laher commented May 5, 2023

laher commented May 6, 2023

tamton-aquib commented Aug 31, 2023

add core.execute #618

add core.execute #618

Conversation

tamton-aquib commented Oct 9, 2022 • edited Loading

max397574 commented Oct 26, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vhyrro commented Feb 23, 2023

laher commented May 5, 2023

tamton-aquib commented May 5, 2023

laher commented May 5, 2023

laher commented May 6, 2023

tamton-aquib commented Aug 31, 2023

add `core.execute` #618

add `core.execute` #618

tamton-aquib commented Oct 9, 2022 •

edited

Loading