Rocks update result in ENONET error after removing rocks-git plugin

[austinliuigi]

When I run :Rocks update, I get the following error:

It worked when I ran it earlier today, but after attempting to lazy-load my plugins with rocks-lazy.nvim I noticed that converting my rocks-git plugins to use opt = true wasn't working; they were staying in ~/.local/share/nvim/site/pack/rocks/start. When I tried uninstalling the plugin and reinstalling, it wouldn't install. I tried reinstalling rocks.nvim by deleting ~/.local/share/nvim/rocks/ and ~/.local/share/nvim/site/pack/ and re-triggering the bootstrap. However, after reinstallation, I still get the error shown in the image when I run :Rocks update.

Update: I figured that this only occurs after removing a rocks-git plugin. So after doing a fresh install of rocks.nvim, this is the sequence I followed:

- run :Rocks sync
- run :Rocks update <= works
- comment out a rocks-git plugin from rocks.toml
- run :Rocks sync
- run Rocks update <= errors

[mrcjkb]

Hey 👋

Thanks for reporting. I'll try to reproduce later today.

[mrcjkb]

Also, This looks suspicious in your config:

local rocks_config = {
    rocks_path = vim.fs.normalize(install_location),
    luarocks_binary = vim.fs.joinpath(install_location, "bin", "luarocks"),
}

That comes from a bug in the readme's old bootstrap snippet.
Can you please try unsetting luarocks_binary?

So that it's

local rocks_config = {
    rocks_path = vim.fs.normalize(install_location),
}

[austinliuigi]

Thanks for taking the time to help track down the issue. I just updated the bootstrap code with the one in the current readme. I reinstalled rocks.nvim, but the same issue occurs. My rocks.nvim config is the following now:

[austinliuigi]

Another issue that may be related and could possibly provide more context : after following these steps after reinstallation that I mentioned above,

- run :Rocks sync
- run :Rocks update <= works
- comment out a rocks-git plugin from rocks.toml
- run :Rocks sync
- run Rocks update <= errors

I also cannot re-install the plugin that I commented out. When I uncomment it and run :Rocks sync, it doesn't install. Note that the sync doesn't show any signs of failing, it just processes for a little while with no progress messages then shows "Completed" when done. It is only when I run :Rocks update that I get the ENONET error.

[mrcjkb]

I haven't been able to reproduce the behaviour you're describing.
But I've also noticed your rocks.nvim installation and its modules (rocks-git, etc.) are quite out of date.

Could you please update to the latest versions and then see if the issue still persists?

You should be able to update them individually with :Rocks install {rock} (e.g. Rocks install rocks.nvim).

[austinliuigi]

I've been running the latest versions, but I just haven't pushed my updated config to github yet. Nevertheless, I tried running :Rocks install rocks.nvim and :Rocks install rocks-git.nvim with a :Rocks sync, but still no luck. Maybe I'll just wait for a few updates and see if the issue fixes itself. Thanks for your help :)

[mrcjkb]

If you push your updated config to another branch and link it for me, I can try and reproduce again 😄

[austinliuigi]

So I was probing the source code of rocks.nvim and rocks-git.nvim to see if I could get more information and I found out why rocks-git wasn't installing plugins. I fixed the issue in this PR. Interestingly, I currently can't reproduce the ENONET error when I :Rocks update, even when I revert the fix for rocks-git not installing plugins. Maybe it's some kind of race condition?

I also mentioned in the PR that rocks-git seems to install plugins fine on the first run of :Rocks sync after a fresh install of rocks.nvim. I'm curious to know f you have any ideas why.

[mrcjkb]

Thanks for digging and for the fix 🙏

I also mentioned in the PR that rocks-git seems to install plugins fine on the first run of :Rocks sync after a fresh install of rocks.nvim. I'm curious to know f you have any ideas why.

I think it could be if rocks-git isn't installed yet. To make sure sync works when you first run it (before extensions like rocks-git are installed), rocks.nvim collects all the rocks it couldn't handle itself, loads external handlers after installing them, and then retries to install the rocks it couldn't install previously.

[austinliuigi]

I see, thanks for the explanation. Since I can't reproduce the ENONET error, this issue could probably be closed but I'll leave that up to you. Thanks for all the help and the great package manager :)