fix: external sync actions not running #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug was introduced by the refactor in commit 704940f, which changed external_actions from a list to a key-value table. However, when iterating through external_actions, we still use ipairs which results in no values. The fix is to use pairs, which properly iterates through all external_actions.
austinliuigi
requested review from
NTBBloodbath,
vhyrro and
mrcjkb
as code owners
Review ChecklistDoes this PR follow the Contribution Guidelines? Following is a partial checklist: Proper conventional commit scoping:
If applicable:
|
mrcjkb
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was introduced by the refactor in commit 704940f, which changed external_actions from a list to a key-value table. However, when iterating through external_actions, we still use ipairs which results in no values.
This caused rocks-git to not run sync actions on any of its rocks, so e.g. adding
fzf-lua = { git = "ibhagwan/fzf-lua" }to your rocks.toml then running:Rocks syncwould not actually install fzf-lua.Note
On my machine, rocks-git properly installs its rocks after a fresh bootstrap of rocks.nvim and an initial
:Rocks sync, but I'm not sure why it works on the first run. After that, rocks-git doesn't run its sync callback due to the bug this PR fixes.