Skip to content

Commit

Permalink
fix: external sync actions not running
Browse files Browse the repository at this point in the history
This bug was introduced by the refactor in commit 704940f,
which changed external_actions from a list to a key-value table.
However, when iterating through external_actions, we still use ipairs
which results in no values. The fix is to use pairs, which properly
iterates through all external_actions.
  • Loading branch information
austinliuigi committed Jul 9, 2024
1 parent 027fe81 commit c964ad5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lua/rocks/operations/sync.lua
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ operations.sync = function(user_rocks, on_complete)
end

-- Sync actions handled by external modules that have registered handlers
for _, callback in ipairs(sync_status.external_actions) do
for _, callback in pairs(sync_status.external_actions) do
ct = ct + 1
callback(report_progress, report_error)
end
Expand Down

0 comments on commit c964ad5

Please sign in to comment.