:Rocks update doesn't update rocks.toml entries of out-of-sync rocks that didn't get updated

[champignoom]

A week ago, I installed rocks.nvim (then 2.30.0), which had some serious bug.

Today, I removed ~/.local/share/nvim/rocks/, re-installed rocks.nvim, but with ~/.config/nvim/rocks.toml unchanged, which has obsolete version info "rocks.nvim" = "2.30.0" in it.

Then I did :Rocks update. But "rocks.nvim" = "2.30.0" stayed there unchanged.

Then I did :Rocks sync as suggested by rocks.nvim, and rocks.nvim got reverted back to 2.30.0, and the bug reappeared.

I would expected that the version info in rocks.toml gets updated by :Rocks update.

[mrcjkb]

Hey 👋

Are you able to reproduce this reliably? If so, could you please provide a :Rocks log?

I was not able to reproduce it on my end.
Edit: Nor in CI: #381

[champignoom]

• rm -rf ~/.local/share/nvim/rocks
• cat ~/.config/nvim/rocks.toml

# ~/.config/nvim/rocks.toml
[rocks]
[plugins]
"rocks.nvim" = "2.30.0"
[plugins.nvim-treesitter]
git = "nvim-treesitter/nvim-treesitter"

• nvim -u NORC -c "source https://raw.githubusercontent.com/nvim-neorocks/rocks.nvim/master/installer.lua"
• nvim, then :Rocks update, it says "Nothing to update! (100%)"
• cat ~/.local/share/nvim/rocks/rocks.log, showing nothing
• cat ~/.config/nvim/rocks.toml, unchanged

[mrcjkb]

🤔 I think I know what your issue is.

:Rocks update only updates rocks.toml entries for rocks that it actually updated.
Since you did a fresh install, but kept your existing rocks.toml, rocks.nvim was already up-to-date, so :Rocks update didn't update rocks.nvim, and therefore didn't update the rocks.toml entry.

To fix this, Rocks update should update every rocks.toml entry's version to the currently installed version, regardless of whether or not it actually updated the rock.