Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(update): set version of all installed rocks.toml entries #382

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented Jun 14, 2024

Fixes #380.

If a rocks.toml entry was set to an older version than a rock that is already up-to-date, then :Rocks update wouldn't update it and the next :Rocks sync would downgrade the rock.

Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

@vhyrro vhyrro force-pushed the updata-all-rocks-toml-entries branch from b1ed224 to 4963371 Compare June 19, 2024 18:26
Fixes #380.
If a rocks.toml entry was set to an older version than a rock
that is already up-to-date, then `:Rocks update` wouldn't update
it and the next `:Rocks sync` would downgrade the rock.
@vhyrro vhyrro force-pushed the updata-all-rocks-toml-entries branch from 4963371 to b8b4e77 Compare June 19, 2024 18:29
@mrcjkb mrcjkb merged commit 56460c8 into master Jun 19, 2024
9 of 10 checks passed
@mrcjkb mrcjkb deleted the updata-all-rocks-toml-entries branch June 19, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

:Rocks update doesn't update rocks.toml entries of out-of-sync rocks that didn't get updated
2 participants