fix(installer): use vim.o.sh instead of 'sh'
#179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, `sh` might not be available (e.g. if not installed with git). Even if git `sh` is installed, it may not see everything that is on the `PATH` (see #166). The default `vim.o.sh` on Windows is `cmd.exe`. On Linux and MacOS, the script should behave as before.
Review ChecklistDoes this PR follow the Contribution Guidelines? Following is a partial checklist: Proper conventional commit scoping:
If applicable:
|
NTBBloodbath
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows,
shmight not be available (e.g. if not installed with git).Even if git
shis installed, it may not see everything that is on thePATH(see #166).The default
vim.o.shon Windows iscmd.exe. On Linux and MacOS, the script should behave as before.