Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(installer): remove unnecessary guards #201

Merged
merged 1 commit into from
Mar 17, 2024
Merged

fix(installer): remove unnecessary guards #201

merged 1 commit into from
Mar 17, 2024

Conversation

vhyrro
Copy link
Collaborator

@vhyrro vhyrro commented Mar 17, 2024

The change is self explanatory :p

@github-actions GitHub Actions
Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

mrcjkb
mrcjkb approved these changes Mar 17, 2024
View reviewed changes
Copy link
Member

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: add installer context to PR title.

@mrcjkb mrcjkb changed the title fix: remove unnecessary guards fix(installer): remove unnecessary guards Mar 17, 2024
@mrcjkb mrcjkb merged commit e3b2e0d into master Mar 17, 2024
8 checks passed
@mrcjkb mrcjkb deleted the remove-guards branch March 17, 2024 13:52
@github-actions github-actions bot mentioned this pull request Mar 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcjkb mrcjkb mrcjkb approved these changes

@NTBBloodbath NTBBloodbath Awaiting requested review from NTBBloodbath NTBBloodbath is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vhyrro @mrcjkb