Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow overriding luarocks config #334

Merged
merged 1 commit into from
May 21, 2024
Merged

feat: allow overriding luarocks config #334

merged 1 commit into from
May 21, 2024

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented May 15, 2024

Closes #330.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited by mrcjkb
Loading

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

@mrcjkb mrcjkb marked this pull request as draft May 15, 2024 14:42
@mrcjkb mrcjkb mentioned this pull request May 19, 2024
Closed
@mrcjkb mrcjkb force-pushed the luarocks-config-override branch from dd0cbb9 to 7f31d73 Compare May 21, 2024 20:31
@mrcjkb mrcjkb force-pushed the luarocks-config-override branch from 7f31d73 to 43032aa Compare May 21, 2024 20:53
@mrcjkb mrcjkb marked this pull request as ready for review May 21, 2024 20:53
@mrcjkb mrcjkb enabled auto-merge (squash) May 21, 2024 20:54
@mrcjkb mrcjkb merged commit 02f77e8 into master May 21, 2024
10 checks passed
@mrcjkb mrcjkb deleted the luarocks-config-override branch May 21, 2024 20:55
@mrcjkb mrcjkb mentioned this pull request May 21, 2024
Merged
@mrcjkb mrcjkb mentioned this pull request Jun 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NTBBloodbath NTBBloodbath Awaiting requested review from NTBBloodbath NTBBloodbath is a code owner

@vhyrro vhyrro Awaiting requested review from vhyrro vhyrro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Allow overriding or extending the luarocks config
1 participant
@mrcjkb