feat(config): import option for splitting rocks toml configs

[simifalaye]

Addresses: #240

This PR aims to add support for config importing/inclusion for the purpose of modularizing your rocks.toml and/or supporting local configuration that is outside of version control.

@vhyrro Had mention making this into a separate module but I think configuration imports is a fairly standard/core feature, so I wanted to implement it right in rocks.nvim. It also seemed easier to deal with the complexities of allowing core rocks.nvim and other modules interact with configuration as if it is one table but ensuring that we write all configuration back to the same files that they came from after modification.

Essentially, we'd need to make a breaking change to the handler API to support a list of MutRocksTomlRef so that modifications could be isolated to each file. To avoid this, I implemented this using a metatable which contains all the configuration tables associated with each config file and then uses the __index and __newindex methods to get the correct table for modification. For the config module, the imports are just merged into the base configuration since that isn't being written back to the config files.

Side Note: There seems to be an issue in toml-edit where toml lists don't properly convert to a lua table when you use the parse function. Only string key tables seem to work for the parse function. I may open an issue in the repo unless there's something I'm missing here.

[mrcjkb]

This looks like a great addition! 🙏

I haven't had a chance to look at it in detail yet, but I'll see if I can find some time in the next few days.

[mrcjkb]

question: if a use case is to have configs that aren't checked into scm, wouldn't it be better to prioritise the imports?

Although, it might be best just to treat conflicts as an error.

[simifalaye]

Yeah, you're right. You'd want imports to have preference over the base config so that you could have local config override scm config if you wanted to do that. Since this is a valid use case, we may now want to raise an error. I'll change it to give preference to the imported config.

[mrcjkb]

The reason I'm not sure if we want to support overrides is because it increases the complexity: When updating plugins that exist in multiple configs, you have to keep track of which toml file(s) to write to.
There might be other subtle things I'm not considering here.

I'm not sure if the ability to override scm configs is strong enough of a use case, which is why I'd say YAGNI for now.

[simifalaye]

I think (correct me if I'm wrong) because both the config and the operations respect config preferences, you will always write back to the config that has higher preference if it exists in both configs. The config.internal module merges all the configurations in order and the operations.helpers module orders the config tables by preference. So, I think it shouldn't add complexity but I may be wrong so I'll leave that up to you to decide.

[mrcjkb]

That's probably correct. But I'm still not sure if it has any implications I'm not foreseeing, which is why I'd rather not support overrides until people ask for it.

[mrcjkb]

come to think about it, we should probably add some tests for this feature.

[simifalaye]

I'll add tests later today.

[simifalaye]

Btw @mrcjkb I opened this issue for toml_edit.lua: (the lua library wrapper and not the original toml-edit) nvim-neorocks/toml-edit.lua#37. I'll take a look at it later but my rust is rusty so it will take me some time. Might be a quick fix for someone who is very familiar since it looks like you'd just need to match on a new toml-edit value type in the parse function (toml_edit::Value::Array)

[mrcjkb]

CI is failing on stylua.

[simifalaye]

@mrcjkb Updated the flake.lock also but not sure if that's needed now for the CI? Feel free to take over the PR to get it through as I'm just new to nix. I believe all of the code, unit tests and style stuff should be addressed now but the CI might need some other things to get new toml-edit changes.

[mrcjkb]

Merging into the split-rocks-toml branch, so I can fix the build there.

[mrcjkb]

@simifalaye I just noticed that since this PR, our integration test on Ubuntu is failing with

E5113: Error while calling lua chunk: ....nvim/rocks.nvim/rocks/share/lua/5.1/luarocks/loader.lua:104: error loading module 'toml_edit' from file '/home/runner/work/rocks.nvim/rocks.nvim/rocks/lib/lua/5.1/toml_edit.so':
	/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /home/runner/work/rocks.nvim/rocks.nvim/rocks/lib/lua/5.1/toml_edit.so)

any idea what could be going on?

[mrcjkb]

nevermind, I've upgraded the Ubuntu runner and it's fixed.