Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installer/bootstrap): pin luarocks to v3.11.1 #569

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented Oct 23, 2024

Should hopefully fix #568.

@ambaradan would you mind testing with the changes in this PR? 🙏

@mrcjkb mrcjkb changed the title fix(installer): pin luarocks to v3.11.1 fix(installer/bootstrap): pin luarocks to v3.11.1 Oct 23, 2024
@ambaradan
Copy link

error

@ambaradan
Copy link

I still have a RHEL at home; I will do some tests on that tonight to rule out any error on my part.

@ambaradan
Copy link

Same thing using luaver

stderr: /home/ambaradan/.luaver/lua/5.1/bin/lua: ...511A84450400/share/lua/5.1/luarocks/core/persist.lua:25: bad argument #1 to '
load' (function expected, got string)

@mrcjkb
Copy link
Member Author

mrcjkb commented Oct 23, 2024

🤔 I just tried running the install script (the one on master) on NixOS, and did not encounter any issues.

The stack trace in your screenshot is definitely for the current HEAD of the master branch of luarocks (load being called in the luarocks.core.persist module on line 25).
On the v3.11.1 tag, there's no load call on that line.

Merging this PR, as it makes sense to pin the version anyway.
After that, you can try again with the regular install script.

@mrcjkb mrcjkb merged commit 259dee5 into master Oct 23, 2024
9 checks passed
@mrcjkb mrcjkb deleted the mj/push-koyuqpqlrzlo branch October 23, 2024 16:04
@ambaradan
Copy link

@mrcjkb The fix solved the problem, now the installation works again even on RHEL, many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation script no longer works
2 participants