feat(api): Add support for install options #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simifalaye
requested review from
NTBBloodbath,
vhyrro and
mrcjkb
as code owners
mrcjkb
requested changes
Nov 4, 2024
simifalaye
commented
Nov 5, 2024
simifalaye
commented
Nov 5, 2024
|
Note @mrcjkb, if i'm seeing this correctly, toml-edit is being pulled in as a nix package and you are the maintainer? If so, toml-edit-0.6.0 will need to be added since only 0.5.0 exists |
|
|
Needs a rebase and conflict resolution (I've bumped the |
|
Should be done. Please review again as I also corrected some things (changing the internal code to use the new api options also) |
mrcjkb
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per this discussion: #575
This PR adds support for install options to the api, specifically, the option to specify a relative config path to install a new rock to. The config path is then added to the imports of the base configuration file.