Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prune) various fixes #60

Merged
merged 4 commits into from
Dec 11, 2023
Merged

fix(prune) various fixes #60

merged 4 commits into from
Dec 11, 2023

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented Dec 9, 2023

Fixes #56.

Note that I have stacked this on #58 to avoid merge conflicts.

Tested manually as specified in #56.

This PR includes 2 fixes and a refactor, so it should be rebase-merged.

@mrcjkb mrcjkb self-assigned this Dec 9, 2023
Copy link
Contributor

github-actions bot commented Dec 9, 2023

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

@mrcjkb mrcjkb force-pushed the fix-prune branch 2 times, most recently from 11e00b6 to 098efcd Compare December 9, 2023 22:01
@mrcjkb mrcjkb force-pushed the fix-prune branch 3 times, most recently from f0cfdad to 29d2247 Compare December 10, 2023 22:19
@mrcjkb mrcjkb merged commit e82f66f into master Dec 11, 2023
4 of 6 checks passed
@mrcjkb mrcjkb deleted the fix-prune branch December 11, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: :Rocks prune removes rock dependencies that are in rocks.toml
1 participant