fix(output_panel): recreate window and term channel if panel closed manually #477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for 2 issues that appear if
output_panel
is closed by the user manually and not withoutput_pannel.toggle/close()
:vim.fn.bufexists()
does not catch buffers that exist, but are unloaded. Fix - recreate the buffer.Also, a fix with associated issue: if you reaload the plugin with say
Lazy reload neotest
, the old panel buffer still exists, so when a new buffer is created with the same name, there is an error of trying to rename existing buffer. Fix - delete buffer with the same name, when ceating a new one.