Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): add supports_method to nio.lsp.Client #21

Merged

Conversation

rcasia
Copy link
Contributor

@rcasia rcasia commented Jun 30, 2024

The straight way to check whether a method is supported is via supports_method.

News 0.10.0:

  • Dynamic registration of LSP capabilities. An implication of this change is
    that checking a client's server_capabilities is no longer a sufficient
    indicator to see if a server supports a feature. Instead use
    client.supports_method(<method>). It considers both the dynamic
    capabilities and static server_capabilities.

For example, nvim-jdtls does not have definitionProvider in server capabilities. See mfussenegger/nvim-jdtls#589 (comment).

Relates to nvim-neotest/neotest#425

@rcarriga rcarriga merged commit a428f30 into nvim-neotest:master Jul 11, 2024
4 checks passed
@rcarriga
Copy link
Contributor

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants