Skip to content

Agenda sort #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 36 commits into from
Closed

Agenda sort #161

wants to merge 36 commits into from

Conversation

gerazov
Copy link
Contributor

@gerazov gerazov commented Nov 23, 2021

Closes #128

@gerazov
Copy link
Contributor Author

gerazov commented Nov 23, 2021

Please squash the commits 😅

@gerazov
Copy link
Contributor Author

gerazov commented Nov 23, 2021

ok now not same day tasks follow todays tasks that follow time of day tasks, I'm trying to sort the tasks now


date.agenda_items = utils.concat(date.agenda_items, date_only.agenda_items, false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gerazov lets go with some solution to do all this sorting in the sort_agenda_items function. Saving all this additional state can potentially slow down agenda rendering, especially on month/year view.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'll refactor 😅

@@ -427,4 +427,31 @@ function utils.promisify(fn)
return fn
end

---debug printing a table
---source https://stackoverflow.com/questions/41942289/display-contents-of-tables-in-lua
function utils.tprint(tbl, indent)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this and use vim.inspect(tbl) instead.

@kristijanhusak
Copy link
Member

@gerazov please squash the commits into a single one, and clean up the commented and unused code.

@kristijanhusak
Copy link
Member

Closing this in favor of ed8a420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure group based sorting in agenda
3 participants