-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Headline:update_cookie() now works for both list and headline children #572
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary? And if we
update_cookie()
here, is there even a need to call it in L208?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The L208 call is necessary because of the
return
statement at L209. The code was written that way when I added the calls toupdate_cookie()
. Prior to my PR, I think the function worked as follows: if the headline is a todo item already, set the node text tokeyword
and then return; if not, insert the TODO keyword into the node.self:update_cookie()
needs to be called after both changes, and there's probably a way to refactor the function to only call it once, but I didn't feel qualified to rewrite the original logic of the function in this PR.As to the other question about
self.refresh()
: the short answer is "because it doesn't work without it." I don't 100% know why the call toself:refresh()
is necessary at L215, but if it isn't there, the value of the headline is wrong whenself:update_cookie()
is called. I suspect it's becausetree_utils.set_node_text()
usesvim.api.nvim_buf_set_text()
to update the node and something inself:refresh()
causes treesitter to get back in sync so that the calls to the treesitter API inself:update_cookie()
return the correctly updated value. It took my over an hour of debugging to settle onself:refresh()
here and I tried several other solutions (includingvim.schedule_wrap()
andvim.defer_fn()
), so I'm pretty confident it has to be called here (unless there's some other solution I didn't try). But I agree with the original question: that call toself:refresh()
looks wrong.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️ of course, my bad
Let's figure out what is going on and then document the code