-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(date): improve type hints #751
Conversation
seflue
commented
Jun 10, 2024
- introduce types for internal date tables
- introduce some helper to encapsulate interaction with os api
@kristijanhusak As promised here the cleaned up type hints in orgmode/tests/plenary/ui/mappings/todo_spec.lua Lines 343 to 357 in ac9a6e0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks ok. I just skimmed through it. See if we need to address some of these comments and then I'll check it thoroughly.
- introduce types for internal date tables - introduce some helper to encapsulate interaction with os api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok this looks good now. I'll do some minor changes after merging, but I don't want to bother you with those nits. Thanks!
- introduce types for internal date tables - introduce some helper to encapsulate interaction with os api Co-authored-by: Sebastian Flügge <seflue@users.noreply.github.com>