Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agenda)!: rewrite agenda rendering and fix filters #848

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

kristijanhusak
Copy link
Member

@kristijanhusak kristijanhusak commented Jan 10, 2025

This PR contains a complete rewrite of agenda logic, in preparation for custom agenda commands.
It also includes few fixes and breaking changes:

Breaking changes:

  1. Agenda category/tags/headline search filters are now case sensitive to align with how Emacs orgmode works. This means that if you have tags as uppercase (for example MYPROJECT), you will need to type it like that in the search. Previously, everything was case insensitive and converted to lowercase.

Fixes:

  1. Tags are rendered using virtual text instead of adding a padding from the headline title to align it. A similar idea was proposed previously in refactor(agenda): use extmarks to set tags in right column #683. This should fix Nvim tags in todo list are not correctly aligned for links #565. This could be considered a BC for users who use a long headline because of the overlap, but most likely it will be ok.
  2. Filtering the agenda using the API ignores categories #483 should be fixed
  3. Few other issues with agenda filters were fixed to be more aligned with Emacs orgmode.

@kristijanhusak kristijanhusak merged commit 8667167 into master Jan 10, 2025
6 checks passed
@kristijanhusak kristijanhusak deleted the refactor/agenda branch January 10, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nvim tags in todo list are not correctly aligned for links
1 participant