-
-
Notifications
You must be signed in to change notification settings - Fork 161
feat(cookie): implement virtual cookies #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PriceHiller
wants to merge
1
commit into
nvim-orgmode:master
Choose a base branch
from
PriceHiller:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -71,6 +71,11 @@ function M.link_highlights() | |
['@org.table.delimiter'] = '@punctuation.special', | ||
['@org.table.heading'] = '@markup.heading', | ||
['@org.edit_src'] = 'Visual', | ||
|
||
-- For cookie extmarks (applicable if enabled) | ||
['@org.cookie.delimiter'] = 'Delimiter', | ||
['@org.cookie.sign'] = 'Special', | ||
['@org.cookie.number'] = 'Number', | ||
Comment on lines
+74
to
+78
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These do look good, but the highlights make it seem like it is real text rendered in the buffer. diff --git a/lua/orgmode/colors/highlights.lua b/lua/orgmode/colors/highlights.lua
index 3601119..2885cdb 100644
--- a/lua/orgmode/colors/highlights.lua
+++ b/lua/orgmode/colors/highlights.lua
@@ -73,9 +73,9 @@ function M.link_highlights()
['@org.edit_src'] = 'Visual',
-- For cookie extmarks (applicable if enabled)
- ['@org.cookie.delimiter'] = 'Delimiter',
- ['@org.cookie.sign'] = 'Special',
- ['@org.cookie.number'] = 'Number',
+ ['@org.cookie.delimiter'] = 'VirtualTextInfo',
+ ['@org.cookie.sign'] = 'VirtualTextInfo',
+ ['@org.cookie.number'] = 'VirtualTextInfo',
}
for src, def in pairs(links) do |
||
} | ||
|
||
for src, def in pairs(links) do | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of things came to mind on this docs entry.
#+begin_src lua
code block to show an example for this config, same as done with the other config options. Something like this:doc/orgmode.txt
for this config optiontype
andenabled
) should probably not be described in individual child headings (****
), but instead in list items, similar to what is done here for theorg_capture_templates
config options:orgmode/docs/configuration.org
Lines 832 to 842 in 32ef9e9