Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: make use_sqlite = false be the default #148

Merged
merged 7 commits into from
Oct 10, 2023
Merged

feat!: make use_sqlite = false be the default #148

merged 7 commits into from
Oct 10, 2023

Conversation

delphinus
Copy link
Member

@delphinus delphinus commented Sep 27, 2023 •
edited
Loading

Fix #91

This totally removes the dependencies for kkharji/sqlite.lua.

TODO

  • Load sqlite.lua lazily even if it does Sqlite.new().
  • Suggest to use native logic and migrate from SQLite DB.
  • Write migration guide doc.

@delphinus delphinus force-pushed the feature/change-default branch 3 times, most recently from a8daaf8 to 2b282a3 Compare October 1, 2023 11:41
@delphinus
Copy link
Member Author

It looks good after my dogfooding for several weeks. Make “native mode” be the default!!

@delphinus delphinus merged commit daf5974 into master Oct 10, 2023
24 checks passed
@delphinus delphinus deleted the feature/change-default branch October 10, 2023 09:17
@delphinus delphinus mentioned this pull request Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dependency on sqlite
1 participant
@delphinus