Picker:delete_selection doesn't work if entry_maker returns nil

[cameronr]

Description

Picker:delete_selection uses ipairs to iterate over the finder.results:

telescope.nvim/lua/telescope/pickers.lua

Lines 836 to 840 in 5972437

	for result_index, result_entry in ipairs(self.finder.results) do
	if vim.tbl_contains(delete_selections, result_entry) then
	table.insert(selection_index, result_index)
	end
	end

If the entry_maker for a one shot job returns nil for one of the lines, it makes the indices discontinuous:

telescope.nvim/lua/telescope/finders/async_oneshot_finder.lua

Lines 66 to 79 in 5972437

	for line in stdout:iter(false) do
	num_results = num_results + 1
	if num_results % await_count then
	async.util.scheduler()
	end
	local entry = entry_maker(line)
	if entry then
	entry.index = num_results
	end
	results[num_results] = entry
	process_result(entry)
	end

Which means the ipairs iteration won't see any of the results after the nil.

Having the entry_maker return {} instead isn't ideal because then the results count is off (i.e. the empty rows aren't displayed but they still show up in the count of results).

I think the correct behavior is for Picker:delete_selection to use pairs instead.

Neovim version

NVIM v0.10.1
Build type: Release
LuaJIT 2.1.1720049189

Operating system and version

macos 14.6

Telescope version / branch / rev

telescope 0.1.8

checkhealth telescope

==============================================================================
telescope: require("telescope.health").check()

Checking for required plugins ~
- OK plenary installed.
- OK nvim-treesitter installed.

Checking external dependencies ~
- OK rg: found ripgrep 14.1.0
- OK fd: found fd 10.1.0

===== Installed extensions ===== ~

Telescope Extension: `advanced_git_search` ~
- No healthcheck provided

Telescope Extension: `fzf` ~
- OK lib working as expected
- OK file_sorter correctly configured
- OK generic_sorter correctly configured

Telescope Extension: `neoclip` ~
- No healthcheck provided

Telescope Extension: `session-lens` ~
- No healthcheck provided

Telescope Extension: `ui-select` ~
- No healthcheck provided

Steps to reproduce

1. Use minimal config
2. Run touch .repro/data/nvim/sessions/ax.vim to create an empty session file (do this in the directory used for the repro). This will cause the entry_maker to return nil for this file
3. run nvim -u repro.lua
4. Save a session via :SessionSave
5. Open session picker via :SessionSearch
6. Try to delete the session you just created (the only one in the picker) with

Expected behavior

The session is deleted and the picker is updated

Actual behavior

Nothing happens because Picker:delete_selection doesn't find the result so it doesn't call the callback to perform the delete

Minimal config

local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.uv.fs_stat(lazypath) then
  vim.fn.system({
    "git",
    "clone",
    "--filter=blob:none",
    "https://github.com/folke/lazy.nvim.git",
    lazypath,
  })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  {
    "nvim-telescope/telescope.nvim",
    dependencies = {
      "nvim-lua/plenary.nvim",
    },
    config = function()
      -- ADD INIT.LUA SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
      require("telescope").setup({})
    end,
  },
  {
    "rmagatti/auto-session",
    lazy = false,
    opts = {},
  },
}

require("lazy").setup(plugins, {
  root = root .. "/plugins",
})