feat: api for clearing completion cb in userspace #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess it's orthogonal enough to #987 to be able to merge it right away. Hope there's nothing more to it 😅
More generally, some lower-lever picker functions (specifically,
default_text,on_complete, or that some options can also be passed to pickers individually likefile_ignore_patterns) useful to end users are not yet documented though we should document these options at least after #987 or as part of #1024.Examples: #1095, #1042, frecency's usage of
on_input_filter_cb, and gitter discussion from which this PR evolved