Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refine results action #1115

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Conversation

fdschmidt93
Copy link
Member

@fdschmidt93 fdschmidt93 commented Aug 13, 2021

Putting this up for discussion.

Actual use cases if someone has telescope-fzf-native:

  • fuzzy refining live grep
  • dynamic lsp workspacye symbols

TO DO/DECIDE:

  • What opts, if not all, should be configurable? If all, results can also be refined via feat: allow caching and resuming picker #1051 (done in stash) though with visible, unavoidable redraw from new picker
  • Why is the prompt prefix not immediately updated?
  • Remove default mapping once decided to keep this
  • Fix highlighting after refinement
  • Should this be the default for live_grep and grep_string on whitespace?

Currently sorter, keeping prompt/prefix/multi selection & showing prev prompt in prefix are configurable. Would need actions.generate from #1062 to override defaults.

Preview: shows prompt is not immediately updated while actual refinement is instant

refine.mp4

@fdschmidt93 fdschmidt93 changed the title Feat: refine results action feat: refine results action Aug 13, 2021
@kylo252
Copy link
Contributor

kylo252 commented Aug 17, 2021

I'm really happy that would be available soon, much better than my naïve implementation that we briefly discussed over on gitter/matrix last week.

Some notes:
I couldn't figure out how to add a highlight group for the previous queries. I'm guessing we can't keep the old one since it will become inconsistent once the results have been filtered, so it needs to be reapplied dynamically instead. Any ideas regarding that?

@fdschmidt93

This comment has been minimized.

@kylo252

This comment has been minimized.

@fdschmidt93

This comment has been minimized.

@Conni2461 Conni2461 changed the base branch from master to dev July 1, 2022 15:15
@Conni2461 Conni2461 marked this pull request as ready for review July 1, 2022 15:48
@Conni2461
Copy link
Member

merging without docs for now, into dev branch

@Conni2461
Copy link
Member

We can add more opts later, i prefer a more minimal feature over not having the feature.

Thanks for staring it @fdschmidt93 <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants