Prevent an exception when err.message is nil #1630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to use go-to-definition using telescope's LSP helper while Sumneko has not completed loading yet, it returns an error response which does not have `message` field. This error handler tries to log an error by accessing `message` field which is a `nil`. That throws an exception in Lua, and using `tostring()` prevents that.
|
The root cause of my issue was fixed in lua-language-server LuaLS/lua-language-server#879 So this change is not necessary for my use case anymore, but you can still merge it if you find it useful. |
|
Yeah. I think we can skip it if the standard requires it to be not null Thanks tho :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use go-to-definition using telescope's
LSP helper while Sumneko lua-language-server has not completed loading yet,
it returns an error response which does not have
messagefield.
This error handler tries to log an error by accessing
messagefield which is anil. Concatenatingnilto a stringthrows an exception in Lua. Using
tostring()prevents that.