-
-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(actions.qflist): make it work with vim quickfix commands #1742
Conversation
…vim-telescope#1739) Changes functions that use `setqflist` in `r` mode to instead use ` ` mode. This makes the Telescope quickfix list action send results to a new list in the quickfix stack instead of overwriting the entries in the current list. Doing so enables `:chistory`, `:colder` and `:cnewer` functions to review results of previous Telescope queries. The location list uses a similar API and is updated in this PR also (ie this also enables `:lhistory`, `:lolder` and `:lnewer`).
049fdeb
to
da9dfb5
Compare
🤔 hmmm I get how practical it is to have new items added to an existing list. But I have a feeling that maybe it should rather be a global option or new function. The thing is many users of telescope expect the behavior of having new quickfix list on send_to_quickfix, like me. Since it's vim default behavior, then it should be the default here, however, with an way for current users to opt-out this change. Otherwise, LGTM. btw great argument #1739 |
@tami5 Just to clarify, after this change you will still see a new quickfix list on Apologies in advance if you already understood all this, just want to make sure we're on the same page. If you could pull down the PR and give it a try I'd greatly appreciate it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, I totally misunderstood it as feature rather than a bug. I did some testing and indeed no big behavior changes to what the user would expected. but rather an access to a new suite of quickfix driven workflows.
Thanks for the clarification @cgsheeh
r
to
when sending to quickfix list (#1739)DON'T EXPECT THIS TO BE UPSTREAMED due to: * nvim-telescope#1228 * https://github.com/nvim-telescope/telescope.nvim/blob/master/CONTRIBUTING.md THIS IS MY PERSONAL changes. port original patch for quickfixhistory picker while considering file name changes etc. * 8d1841b ("feat: quickfixhistory picker (nvim-telescope#1878)", 2022-05-04) * 0621c1c ("break: prefix internal files and add deprecation messages (nvim-telescope#2032)", 2022-07-01) Related: * nvim-telescope#1739 * nvim-telescope#1742 * https://github.com/cgsheeh/telescope.nvim (forked repo) TODO: make this external https://github.com/nvim-telescope/telescope.nvim/blob/master/developers.md Signed-off-by: Osamu Aoki <osamu@debian.org>
Changes functions that use
mode. This makes the Telescope quickfix list action send results
setqflist
inr
mode to instead useto a new list in the quickfix stack instead of overwriting the
entries in the current list. Doing so enables
:chistory
,:colder
and
:cnewer
functions to review results of previous Telescopequeries.
The location list uses a similar API and is updated in this PR also
(ie this also enables
:lhistory
,:lolder
and:lnewer
).