Force buffer delete for terminal

[TheMeaningfulEngineer]

Closes #1940

Acceptance criteria listed in the issue.

[TheMeaningfulEngineer]

@Conni2461
I was hoping to add some prettier error handling for cases where one tries to close an unsaved buffer.
If you try doing it now there is a lot of ugly red errors printed.

Do you know how can the errors from vim.api.nvim_buf_delete(selection.bufnr, { force = force }) be handled to show a human friendlier error?

I've tried wrapping it with pcall but that didn't prevent the errors from printing.

[Conni2461]

Doing

pcall(vim.api.nvim_buf_delete, selection.bufnr, { force = force }) goes from this error:

E89: No write since last change for buffer 18 (add ! to override)
E5108: Error executing lua [string ":lua"]:1: Failed to unload buffer.
stack traceback:
        [C]: in function 'nvim_buf_delete'
        [string ":lua"]:1: in main chunk

to this

E89: No write since last change for buffer 18 (add ! to override)

I think the latter one in an improvement, and you could add the pcall. You can't catch that error because pcall only catches lua errors and this seems to come from somewhere in neovim (old viml land).

[TheMeaningfulEngineer]

Thanks @Conni2461.
However enclosing the call with pcall doesn't change the verbosity level for me.
I've pushed the second commit with this.
This code produces the exact same error as when pcall isn't present.

Does running this on your machine gives you the reduced error log?

My bad, totally missed the way pcall handles parameters :)

[TheMeaningfulEngineer]

@Conni2461
Hey, can this be merged?

[Conni2461]

Thanks for the PR :) i cleaned it up, wrote docs and changed the target branch to the dev branch following #1938 because i dont consider this a fix and only fixes are currently merged into master (you've also opened this as feature request). It will hit master in about 2 weeks.

Thanks again for improving actions.delete_buffer as well as Picker:delete_selection