chore: clear previewer if no item is selected #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conni2461
force-pushed
the
chore/clear_previewer
branch
from
9b9ba45 to
49ccfcb
Compare
|
LGTM & works for me :) One thing that maybe comes to mind from quick test drive is that dynamic titles persist. I guess we could let those try to fall back to the static title (not required from my end, just trying to pre-empt what follow-up issues may arise 😅 ), which should typically be accessible via |
Conni2461
force-pushed
the
chore/clear_previewer
branch
from
49ccfcb to
f59848c
Compare
|
forgot about the title 😆 fallback to static_title and then fallback to empty string which means no border title. I think that is good enough 😆 |
Conni2461
added a commit
that referenced
this pull request
Jun 15, 2022
Conni2461
added a commit
that referenced
this pull request
Jun 18, 2022
Conni2461
added a commit
that referenced
this pull request
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1702