feat(lsp): use native lsp handlers for some pickers #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch the following pickers to use the native neovim lsp handler functions using the `on_list` option: - `references` -> `vim.lsp.buf.references` - `definitions` -> `vim.lsp.buf.definition` - `type_definitions` -> `vim.lsp.buf.type_definition` - `implementations` -> `vim.lsp.buf.implementation` This offloads the request and response handling off the neovim. This also let's responses pass through any custom handlers registered via `vim.lsp.handlers`. This only affects users on neovim 0.11+. The `on_list` option was introduced in nvim 0.10 but only recently in 0.11, has neovim's `vim.lsp.buf.*` functions added improved support for responses from multiple language servers.
jamestrew
added a commit
that referenced
this pull request
Oct 29, 2024
This reverts commit 6c468ff.
jamestrew
added a commit
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the following pickers to use the native neovim lsp handler functions using the
on_listoption:references->vim.lsp.buf.referencesdefinitions->vim.lsp.buf.definitiontype_definitions->vim.lsp.buf.type_definitionimplementations->vim.lsp.buf.implementationThis offloads the request and response handling off the neovim.
This also let's responses pass through any custom handlers registered via
vim.lsp.handlers(currently not functional on neovim nightly).This only affects users on neovim 0.11+. The
on_listoption was introduced in nvim 0.10 but only recently in 0.11, has neovim'svim.lsp.buf.*functions added improved support for responses from multiple language servers.closes #3336