Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlights(rust): support doc_comment #2232

Closed
wants to merge 2 commits into from

Conversation

theHamsta
Copy link
Member

@theHamsta theHamsta commented Jan 10, 2022

Copy link
Member

@vigoux vigoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add an markdown injection too?

@theHamsta
Copy link
Member Author

theHamsta commented Jan 10, 2022

The leading //! might be a bit of a problem. Maybe I have time to look at @combined injection at weekend

image

So it has problems with headings and code blocks.

image

@theHamsta
Copy link
Member Author

I don't know whether this is ready for markdown injection without the trimming.

@vigoux
Copy link
Member

vigoux commented Jan 11, 2022

Then no markdown injection for now, but maybe add a To-do just so that we remember that.

@theHamsta theHamsta force-pushed the rust-doc_comment branch 4 times, most recently from 344b37d to a01857d Compare January 11, 2022 11:22
@theHamsta theHamsta requested a review from vigoux January 13, 2022 20:37
@vigoux
Copy link
Member

vigoux commented Jan 14, 2022

You'll need to rebase that on master.

@theHamsta theHamsta enabled auto-merge (rebase) January 14, 2022 09:02
@theHamsta
Copy link
Member Author

This commit got reverted in eeb0702ebdac504b97196577b1dac43c80913d7b in tree-sitter-rust

@theHamsta theHamsta closed this Jan 14, 2022
auto-merge was automatically disabled January 14, 2022 10:35

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants