This repository has been archived by the owner on Jan 17, 2024. It is now read-only.
Playground: check for nodes out of range (EOF) #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The playground will try to set the cursor to an invalid position (nvim_win_set_cursor) if the node starts at the EOF mark. ```ruby def run a = <<~EOF end ```
stsewd
commented
Jul 9, 2021
| if start_row > last_row then | ||
| start_row = last_row | ||
| start_col = last_col | ||
| end | ||
|
|
||
| M.highlight_nodes(bufnr, { node }) |
There was a problem hiding this comment.
this doesn't error for that type of nodes, so all good.
|
I am pretty puzzled by this bug tbh. There is multiple PRs, at multiple places, where we try to address such issues, and that's weird |
|
I agree this should be part of the parser, but we should handle those cases gracefully instead of showing errors on every cursor move. |
|
Reported this upstream tree-sitter/tree-sitter-ruby#182 |
theHamsta
approved these changes
Jul 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The playground will try to set the cursor
to an invalid position (nvim_win_set_cursor) if the node starts at the EOF mark.
found this while debugging nvim-treesitter/nvim-treesitter#1531