[Feature] Rename popup

[kristijanhusak]

Hi,

what do you think about introducing rename popup similar to coc.nvim?

[glepnir]

Okay support it later. but find a way to make it beautiful than coc

[glepnir]

[kristijanhusak]

Looks good. Only thing that I noticed is that it has 2 rows instead of 1. Is that on purpose or?

[glepnir]

yep.. because 1 row looks too thin ..what do you think 1 is better?

[kristijanhusak]

I guess it can be configurable. 2 is a bit too big for me because I use some additional line spacing. Passing an configuration to rename() function would work I guess.

[glepnir]

opts.rename_row ?

[kristijanhusak]

Yeah that is fine.

[glepnir]

done.

[kristijanhusak]

Thanks. I'll give it a test in couple of hours.

[kristijanhusak]

I gave it a try, it's working ok. 1 row is perfect. I just noticed one thing. After I do rename, it triggers an autocompletion in my main window. Is there a way to prevent this from happening? It's not a big deal, but if it's a simple fix, guess it can be fixed. Here's the gif:

[glepnir]

reproduce with nvim-compe. works fine with completion-nvim.. I will check it.

[glepnir]

Should be fixed.

[glepnir]

with new ui

[kristijanhusak]

@glepnir works great, thanks!

[nghialm269]

@glepnir is it possible to prefill the rename input with prepareRename placeholder or <cword> just like what vim.lsp.buf.rename() does?

[glepnir]

I’m not sure this is useful or it’s noise to some people, But I will add an option to control this.

[kristijanhusak]

I'd also like that option, thanks.

[glepnir]

Hmm got some problem. can't set text into prompt buffer...

[kristijanhusak]

@glepnir Maybe it's because of neovim issue. See RishabhRD/nvim-lsputils#19 (comment)

[glepnir]

I had talk to bfredl ..need fixed in upstream. I will take a look at neovim when i have time :)