Nvim11 position encoding fix #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ms`, and `make_range_params`. They work the same way but has been given warnings if offset_encoding (or position_encoding) isn't passed.
default options but overlapped with git signs expansion.
match rest of code
|
lint fix thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to always pass a offset_encoding to
make_given_range_paramsandmake_position_params. This is now a warning in nvim 11 even though the functionality hasnt changed, so it's backwards compatible.Also slight refactorting, add util function
get_offset_encodingwith table for filtering how to get it to match new nvim api. This is used everywhere now.