Skip to content

Commit

Permalink
[github] modify the issue template
Browse files Browse the repository at this point in the history
  • Loading branch information
@ljharb
ljharb committed Dec 28, 2016
1 parent 853afbf commit 186509b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@

- Is there anything in any of your profile files (`.bashrc`, `.bash_profile`, `.zshrc`, etc) that modifies the `PATH`?

<!-- if this does not apply, please delete this section -->
- If you are having installation issues, or getting "N/A", what does `curl -v nodejs.org/dist/` print out?
<details>
<!-- do not delete the following blank line -->
Expand Down

5 comments on commit 186509b

@exportingood
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

186509b#diff-1a1c3dd142f76a5fad803a0c52839881

@ljharb
Copy link
Member Author

@ljharb ljharb commented on 186509b Mar 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can I help you?

@exportingood
Copy link

@exportingood exportingood commented on 186509b Mar 15, 2017 •
edited by ljharb
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the problem

If $MANPATH is set, manpath will simply display its contents and issue a warning.

By fa22d71 for #1413, nvm now will declare the "MANPATH" variable, no matter if it's set or not, so in the situation that $MANPATH is set, you'll get the warning:

manpath: warning: $MANPATH set, ignoring /etc/manpath.config

---
 nvm.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nvm.sh b/nvm.sh
index c3a2ff9..9664ba8 100755
--- a/nvm.sh
+++ b/nvm.sh
@@ -2668,8 +2668,8 @@ nvm() {
       # Prepend current version
       PATH="$(nvm_prepend_path "$PATH" "$NVM_VERSION_DIR/bin")"
       if nvm_has manpath; then
-        local MANPATH
         if [ -z "$MANPATH" ]; then
+          local MANPATH
           MANPATH=$(manpath)
         fi
         # Strip other version from MANPATH

@ljharb
Copy link
Member Author

@ljharb ljharb commented on 186509b Mar 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah - if you're saying that that change (not the one you're currently commenting on) causes a warning, could you please file a new issue, and fill out the issue template?

@PeterDaveHello
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1430

Please sign in to comment.