Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy_packages doesn't work with symlink in install path #113

Closed
ohmantics opened this issue May 24, 2012 · 5 comments
Closed

copy_packages doesn't work with symlink in install path #113

ohmantics opened this issue May 24, 2012 · 5 comments
Labels
bugs Oh no, something's broken :-( needs followup We need some info or action from whoever filed this issue/PR.

Comments

@ohmantics
Copy link

The output of npm -g -p ll has elements like:

/Users/alexr/.nvm/v0.6.14/lib/node_modules/npm/node_modules/which:which@1.0.5:/Volumes/Data/Users/alexr/.nvm/v0.6.14/lib/node_modules/npm/node_modules/which

Note that /Users is a symlink to /Volumes/Data/Users. The grep inside the expression for INSTALLS fails to match.

@ljharb ljharb added the bugs Oh no, something's broken :-( label Oct 15, 2014
@ljharb
Copy link
Member

ljharb commented Oct 15, 2014

@ohmantics I've changed the way copy-packages gets its list of packages to install - can you try on the latest released version (v0.17.2 as of today) and see if this is still an issue?

@ljharb ljharb added the needs followup We need some info or action from whoever filed this issue/PR. label Oct 15, 2014
@MethodGrab
Copy link

I'm using nvm 0.17.3 and I also have issues with symlinks, specifically global packages symlink installed with npm link.

nvm copy-packages seems to be choking on tree characters (└──). I've tested this copying from 0.10.33 -> 0.10.32 & from 0.10.33 -> 0.11.14, heres the console output:

$ nvm copy-packages 0.10.33

Copying global packages from v0.10.33...
npm ERR! addLocal Could not install /Users/mg/projects/my-symlinked-module/└──
npm ERR! registry error parsing json
npm ERR! Darwin 14.0.0
npm ERR! argv "node" "/Users/mg/.nvm/v0.11.14/bin/npm" "install" "-g" "--quiet" "bower" "gulp" "my-symlinked-module" "->" "/Users/mg/projects/my-symlinked-module"
npm ERR! node v0.11.14
npm ERR! npm  v2.1.4
npm ERR! path /Users/mg/projects/my-symlinked-module/└──
npm ERR! code ENOENT
npm ERR! errno -2

npm ERR! ENOENT, open '/Users/mg/projects/my-symlinked-module/└──'
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <http://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/mg/projects/my-symlinked-module/npm-debug.log

$ ~/projects/my-symlinked-module

@ljharb
Copy link
Member

ljharb commented Oct 24, 2014

@MethodGrab Hmm, I've used copy-packages with npm linked modules, and although it doesn't preserve the link (which is a problem), it does reinstall from npm successfully. Can you provide steps I could use on a clean system to recreate the scenario you're describing?

@MethodGrab
Copy link

Hmm, I can't seem to make a test case that can reproduce the problem!
I guess it must have been something specific to my environment.

@ljharb
Copy link
Member

ljharb commented Apr 5, 2015

@ohmantics / @MethodGrab: Please check the latest version of nvm - npm link-ed packages should now work, which should fix this issue. (#693)

@ljharb ljharb closed this as completed Apr 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugs Oh no, something's broken :-( needs followup We need some info or action from whoever filed this issue/PR.
Projects
None yet
Development

No branches or pull requests

3 participants