Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support npm link for reinstall-packages #693

Merged
merged 2 commits into from
Mar 19, 2015
Merged

Conversation

hax
Copy link
Contributor

@hax hax commented Mar 17, 2015

No description provided.

@hax hax force-pushed the reinstall-links branch from 247345b to 3d69cf7 Compare March 17, 2015 07:56
@hax
Copy link
Contributor Author

hax commented Mar 18, 2015

Oops. Don't know what fail messages mean:

The command "(mkdir /tmp/urchin && cd /tmp/urchin && curl -s "$(curl -s https://registry.npmjs.com/urchin | grep -Eo '"tarball":\s_"[^"]+"' | tail -n 1 | awk -F" '{ print $4 }')" -O && tar -x -f urchin_)" failed and exited with 56 during .

@ljharb
Copy link
Member

ljharb commented Mar 18, 2015

Does test/slow/nvm reinstall-packages/test-npmlink/index.js need +x file permissions? (the web UI doesn't tell me if it has it or not)

As for that specific failure, it might have been a fluke - I restarted it, and hopefully it will pass this time, or at least have a more helpful error message.

@ljharb ljharb self-assigned this Mar 18, 2015
@hax
Copy link
Contributor Author

hax commented Mar 18, 2015

All passed!
So it means I already added +x :)

@ljharb
Copy link
Member

ljharb commented Mar 19, 2015

@hax this is awesome. Thanks for doing this!

I believe the only remaining holes for reinstall-packages-from are:

  • packages originally installed from git
  • packages that weren't installed at all
  • possibly packages that are installed from private registries.

ljharb added a commit that referenced this pull request Mar 19, 2015
support npm link for reinstall-packages
@ljharb ljharb merged commit 65a986c into nvm-sh:master Mar 19, 2015
@ljharb ljharb added installing node Issues with installing node/io.js versions. feature requests I want a new feature in nvm! bugs Oh no, something's broken :-( labels Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugs Oh no, something's broken :-( feature requests I want a new feature in nvm! installing node Issues with installing node/io.js versions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants