Improve readability & complexity by nvm_has_not_aliased_exec() #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Mar 21, 2017
nvm.sh
Outdated
| @@ -39,6 +39,12 @@ nvm_has() { | |||
| type "${1-}" > /dev/null 2>&1 | |||
| } | |||
|
|
|||
| nvm_has_not_aliased_exec() { | |||
There was a problem hiding this comment.
let's name this nvm_has_non_aliased instead
nvm.sh
Outdated
| @@ -39,6 +39,12 @@ nvm_has() { | |||
| type "${1-}" > /dev/null 2>&1 | |||
| } | |||
|
|
|||
| nvm_has_not_aliased_exec() { | |||
| if ! nvm_has "${1-}" || nvm_is_alias "${1-}"; then | |||
There was a problem hiding this comment.
can this function body just be nvm_has "${1-}" && ! nvm_is_alias "${1-}"?
ljharb
added
the
needs followup
PeterDaveHello
force-pushed
the
nvm_has_not_aliased_exec
branch
2 times, most recently
from
73ada3c to
feabe9f
Compare
ljharb
approved these changes
Mar 22, 2017
ljharb
force-pushed
the
nvm_has_not_aliased_exec
branch
from
feabe9f to
fa3631f
Compare
ljharb
removed
the
needs followup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.