-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] Move to Ubuntu 14.04 on Travis CI #1458
Conversation
Since Ubuntu 12.04 is pretty old now, it's also going to EOL next month, maybe we can just move on Ubuntu 14.04 first.
The first build failed since log is too long, the second build failed since the |
I'm confused; the You're saying that #1334 works on Ubuntu 12 but breaks on Ubuntu 14? |
The logs are too many that the test will be killed as you can see in the raw logs, and yes, #1334 is broken on Ubuntu 14.04, and it's just because its logic is just wrong, as you can see here: Ubuntu 14.04: Ubuntu 12.04: Not sure why nvm is already enabled even we do nothing in Ubuntu 12.04 on Travis CI |
Why are the logs too large for ubuntu 14, but not for ubuntu 12? |
Actually I am not very sure about this part yet, but IMO the log is truly too long, maybe we shouldn't write everything to the standard output, maybe just file, or just to enable the |
k, #1334 is closed; let's try rebasing this on top of that. I'm still not convinced about removing |
89f55e4
to
4ea85ef
Compare
Another point I can't understand ... it just passed the tests without removing |
Anything else I can do? |
Maybe the too long log failed it's caused by the failed test, which prints long log? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does using trusty enable us to drop some of the addons?
Don't think so, but it's good to migrate to the newer environment (though actually 14.04 is not new at all 😅 ) |
4ea85ef
to
93c1036
Compare
Since Ubuntu 12.04 is pretty old now, it's also going to EOL next month,
maybe we can just move on Ubuntu 14.04 first.