Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Move to Ubuntu 14.04 on Travis CI #1458

Merged
merged 1 commit into from
Mar 30, 2017

Conversation

PeterDaveHello
Copy link
Collaborator

Since Ubuntu 12.04 is pretty old now, it's also going to EOL next month,
maybe we can just move on Ubuntu 14.04 first.

Since Ubuntu 12.04 is pretty old now, it's also going to EOL next month,
maybe we can just move on Ubuntu 14.04 first.
@PeterDaveHello
Copy link
Collaborator Author

The first build failed since log is too long, the second build failed since the npm detection bug and will be fixed in #1334

@ljharb
Copy link
Member

ljharb commented Mar 27, 2017

I'm confused; the x is there intentionally so the failure messages will be more useful, and I want to keep it.

You're saying that #1334 works on Ubuntu 12 but breaks on Ubuntu 14?

@PeterDaveHello
Copy link
Collaborator Author

PeterDaveHello commented Mar 28, 2017

The logs are too many that the test will be killed as you can see in the raw logs, and yes, #1334 is broken on Ubuntu 14.04, and it's just because its logic is just wrong, as you can see here:

Ubuntu 14.04:
https://travis-ci.org/PeterDaveHelloKitchen/nvm/builds/215792358

Ubuntu 12.04:
https://travis-ci.org/PeterDaveHelloKitchen/nvm/builds/215792662

Not sure why nvm is already enabled even we do nothing in Ubuntu 12.04 on Travis CI

@ljharb
Copy link
Member

ljharb commented Mar 28, 2017

Why are the logs too large for ubuntu 14, but not for ubuntu 12?

@PeterDaveHello
Copy link
Collaborator Author

PeterDaveHello commented Mar 28, 2017

Actually I am not very sure about this part yet, but IMO the log is truly too long, maybe we shouldn't write everything to the standard output, maybe just file, or just to enable the -x manually if test failed, otherwise, the overhead to the CI is too huge.

@ljharb
Copy link
Member

ljharb commented Mar 28, 2017

k, #1334 is closed; let's try rebasing this on top of that.

I'm still not convinced about removing -x; i went to a lot of trouble to add it and I don't understand why travis log lengths would need to be different on different ubuntu versions.

@PeterDaveHello PeterDaveHello force-pushed the travis-ubuntu-14.04 branch 5 times, most recently from 89f55e4 to 4ea85ef Compare March 28, 2017 09:03
@PeterDaveHello
Copy link
Collaborator Author

PeterDaveHello commented Mar 28, 2017

Another point I can't understand ... it just passed the tests without removing -x, so maybe we can just leave it alone now.

@PeterDaveHello
Copy link
Collaborator Author

Anything else I can do?

@PeterDaveHello
Copy link
Collaborator Author

Maybe the too long log failed it's caused by the failed test, which prints long log?

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does using trusty enable us to drop some of the addons?

@PeterDaveHello
Copy link
Collaborator Author

Don't think so, but it's good to migrate to the newer environment (though actually 14.04 is not new at all 😅 )

@ljharb ljharb force-pushed the travis-ubuntu-14.04 branch from 4ea85ef to 93c1036 Compare March 30, 2017 05:34
@ljharb ljharb merged commit 93c1036 into nvm-sh:master Mar 30, 2017
@PeterDaveHello PeterDaveHello deleted the travis-ubuntu-14.04 branch March 30, 2017 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants