Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Don't override Mac M1 architecture for node ^14.17 #2777

Merged
merged 1 commit into from
Oct 8, 2022
Merged

[Fix] Don't override Mac M1 architecture for node ^14.17 #2777

merged 1 commit into from
Oct 8, 2022

Conversation

joshkel
Copy link
Contributor

@joshkel joshkel commented Mar 30, 2022

Fixes #2743

@joshkel @rluvaton @ljharb
[Fix] Don't override Mac M1 architecture for node ^14.17
c6269e0 
Fixes #2743

Co-authored-by: Josh Kelley <joshkel@gmail.com>
Co-authored-by: Raz Luvaton <16746759+rluvaton@users.noreply.github.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
ljharb
ljharb requested changes Mar 31, 2022
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i suspect we don't have existing tests to cover this line, in which case you're off the hook :-) but if we do, it'd be great to adjust them.

nvm.sh Outdated Show resolved Hide resolved
@ljharb ljharb marked this pull request as draft June 21, 2022 04:10
@ljharb ljharb changed the title Don't override Mac M1 architecture for recent Node 14.x [Fix] Don't override Mac M1 architecture for node ^14.17 Oct 8, 2022
@ljharb ljharb marked this pull request as ready for review October 8, 2022 16:32
@ljharb ljharb merged commit c6269e0 into nvm-sh:master Oct 8, 2022
@joshkel joshkel deleted the mac-arm-node-14 branch October 11, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rluvaton rluvaton rluvaton left review comments

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mac M1 Arm, and architecture override
3 participants
@joshkel @ljharb @rluvaton