[Perf] Improve performance of listing aliases #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I definitely wouldn't want to do that; sorting is necessary for determinism. |
ljharb
approved these changes
Mar 12, 2023
Comment on lines
-1381
to
+1377
| VERSIONS="$(command printf '%s' 'system')" | ||
| VERSIONS="system" |
ljharb
added
the
performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3054
Depending on the run, these changes improve the speed of
npm lsby anywhere from 5% to 30% depending on the run, though it seems to average around 10%. It's not as much as I would like, but it's something.I can get much better performance if I modify
nvm_list_aliasesto only have onewaitcall and nosort. It may be worth adding an option--unsortedwhich does exactly this, but I'm not familiar enough with argument parsing in sh to implement this myself.