System-wide installation of nvm #390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… passing in NVM_DIR to install script
briangonzalez
changed the title
|
This should be good but should also be added to But this feature is also part of my pull request which still has to be reviewed by @ljharb. Probably should write some tests for the installer though.. |
|
Ah, didn't see that one. Thanks for pointing it out. Do you have an open issue as well, or only PR? |
|
Going to close this PR and cede to this PR. It's the right thing to do : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a means for system-wide installation of nvm by explicitly passing in NVM_DIR to install script
This attempts to fix Issue #389