Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export NVM_DIR in profile before sourcing nvm.sh #428

Merged
merged 1 commit into from
May 29, 2014
Merged

export NVM_DIR in profile before sourcing nvm.sh #428

merged 1 commit into from
May 29, 2014

Conversation

koenpunt
Copy link
Contributor

As there are still issues with directory discovery (#394), I suggest we export the NVM_DIR variable before sourcing.

With my changes the snippet added to the profile looks like this:

export NVM_DIR="/Users/koenpunt/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh"  # This loads nvm

@ljharb
Copy link
Member

ljharb commented May 28, 2014

Should NVM_DIR be stored in the profile as $HOME/.nvm rather than the expanded path?

@koenpunt
Copy link
Contributor Author

Nope, because NVM_DIR is variable

On Wednesday, May 28, 2014, Jordan Harband notifications@github.com wrote:

Should NVM_DIR be stored in the profile as $HOME/.nvm rather than the
expanded path?


Reply to this email directly or view it on GitHubhttps://github.com//pull/428#issuecomment-44453777
.

ljharb added a commit that referenced this pull request May 29, 2014
export NVM_DIR in profile before sourcing nvm.sh
@ljharb ljharb merged commit 931cc45 into nvm-sh:master May 29, 2014
@ljharb
Copy link
Member

ljharb commented May 29, 2014

Let's still try to fix directory discovery across shells though.

@koenpunt koenpunt deleted the export-nvm-dir-in-profile branch June 19, 2014 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants