Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install / run issues on Ubuntu #484

Closed
wants to merge 2 commits into from

Conversation

lloydwatkin
Copy link

This fixes issues on Ubuntu 14.04 for myself. Sorry there's no tests but hopefully this is a help towards a solution.

See #483
Fixes #394

@ljharb
Copy link
Member

ljharb commented Jul 24, 2014

Thanks for the contribution! I'm very hesitant to add OS-specific fixes, especially without tests that can automatically run on that OS.

@lloydwatkin
Copy link
Author

I totally see where you are coming from on this. But at least we're
discussing solutions :)

It did occur to me that the second part of the check could be for $HOME
being part of $NVM_DIR.

This makes it no longer OS specific and won't break thinks for anyone.

How would that work for you?

If you could point me at where a test for/like this would live I'd be happy
to take a stab at adding a couple. Presumably set $NVM_DIR to something
'bad' and see that it gets overwritten.

Cheers, Lloyd.

@ljharb
Copy link
Member

ljharb commented Jul 25, 2014

Unfortunately it'd be perfectly valid for someone to set $NVM_DIR to be something that's not in $HOME.

I'm not sure if it's possible to do an Ubuntu-specific test on Travis - that'd be the difficulty in testing for it.

I'd love to discover why this one OS out of all of them is causing problems, and see if there's a way we could indeed construct a test that would simulate the behavior without having ubuntu.

@ljharb ljharb force-pushed the master branch 5 times, most recently from 3a0b1b5 to fd9e01b Compare August 22, 2014 09:38
@ljharb ljharb added needs followup We need some info or action from whoever filed this issue/PR. installing node Issues with installing node/io.js versions. labels Oct 14, 2014
@ljharb
Copy link
Member

ljharb commented Jun 26, 2016

Closing this for now - will be happy to reopen if you still have an interest.

@ljharb ljharb closed this Jun 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugs Oh no, something's broken :-( installing node Issues with installing node/io.js versions. needs followup We need some info or action from whoever filed this issue/PR. OS: ubuntu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problem about installing nvm on ubuntu 1310
2 participants