Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Latest" branch #561

Closed
wants to merge 1 commit into from
Closed

"Latest" branch #561

wants to merge 1 commit into from

Conversation

brock
Copy link
Contributor

@brock brock commented Oct 26, 2014

This proposes using a "latest" branch, instead of the latest version number for the install script. IE:

curl https://raw.githubusercontent.com/creationix/nvm/latest/install.sh | bash

It updates the build tool to merge the most recent tag into the "latest" branch as part of the make release process. Internally, the version numbers still operate as before.

…ber of the tag, but merges that into the latest branch on each build.
@ljharb
Copy link
Member

ljharb commented Oct 27, 2014

Thanks - noting that this is to fix #522.

I'm still not convinced that a branch is the proper solution, but a PR will help me evaluate that better :-)

@ljharb ljharb self-assigned this Oct 27, 2014
@ljharb ljharb added the installing node Issues with installing node/io.js versions. label Oct 27, 2014
@brock
Copy link
Contributor Author

brock commented Oct 27, 2014

@ljharb Thanks man. No worries if this isn't the route you guys want to go with the project. Seems like there is a lot of discussion around the issue ( #400, #469, #547 ), so I thought I'd submit a PR to demonstrate this particular approach.

@ljharb ljharb mentioned this pull request Dec 22, 2014
@ljharb
Copy link
Member

ljharb commented Dec 22, 2014

Closing per #522. http://latest.nvm.sh now redirects, via Github releases, to the latest version. I prefer this method to abusing tags and/or branches.

Thanks for the contribution though!

@ljharb ljharb closed this Dec 22, 2014
ljharb added a commit that referenced this pull request Dec 22, 2014
Add `nvm_get_latest`

This relates to #522, #561, #400.

`nvm_get_latest` uses http://latest.nvm.sh which redirects to https://github.com/creationix/nvm/releases/latest which in turn redirects to the latest release tag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installing node Issues with installing node/io.js versions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants