Vagrant #578
Closed
Vagrant #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 15, 2014 22:22
[Vagrant](https://www.vagrantup.com/) allows us to test all changes in a virtual machine. We can "vagrant up" into a clean environment and "vagrant destroy" whenever
This method copies the folder containing install.sh (normally also containing the repo) to $NVM_DIR - unless of course the install.sh being executed is in $NVM_DIR (where nvm was installed) This is useful for vagrant to test local changes instead of pulling them from git and thus testing what's on the server and not local changes
| @@ -109,6 +109,18 @@ nvm_do_install() { | |||
| exit 1 | |||
| fi | |||
| install_nvm_as_script | |||
| elif [ "~$METHOD" = "~copy" ]; then | |||
There was a problem hiding this comment.
The "copy" functionality is separate from the vagrant stuff - can you split this into two separate PRs, please? The vagrant PR will need a lot of time for me to evaluate it first, and I'd like more context on the usefulness of the "copy" install method, which would be best discussed in a dedicated thread :-)
ghost
mentioned this pull request
Closed
This reverts commit 6acce52.
ghost
mentioned this pull request
added 2 commits
November 16, 2014 15:52
When vagrant is provisioned it will choose an automatic method from now (which means git or script with the newest version of nvm from the web)
Make is needed for the tests to run The tests don't run with with either as `npm test` uses the "shell" package which tries to execute shell commands in its parent shell. If the shell is fish..well, it doesn't work.
ljharb
added
the
needs rebase
|
@LoveIsGrief do you have any interest in completing this PR? |
|
Nah, it's cool. |
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I included vagrant to the repo for testing in an isolated environment. I'm not sure what I should write to test this since all it does is "provision" a virtual machine. Hopefully you'll find it useful.
Cheers